62305[TASK] Put logic of fetching page content from cache into more readable format
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Daniel Gorges +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Daniel Gorges +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 914
-
Benni Mack uploaded patch set 1 11/12/19, 13:55
-
TYPO3com voted on patch set 1 V -1 11/12/19, 14:03 Completed build in 08m 10s on Tue, 12 Nov, 02:03 PM Test Summary: 36314 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38301
-
TYPO3com voted on patch set 1 V +1 11/12/19, 16:08 Completed build in 2h 21m 05s on Tue, 12 Nov, 04:08 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38301
-
Markus Klein commented on patch set 1 11/12/19, 16:17
TypoScriptFrontendController.php:1804Unresolvedstring-cast hereTypoScriptFrontendController.php:1816Unresolvedhere too -
Benni Mack uploaded patch set 2 11/12/19, 16:23
-
Markus Klein commented on patch set 2 11/12/19, 16:30
TypoScriptFrontendController.php:1797Why moving this before the early return? -
TYPO3com voted on patch set 2 V +1 11/12/19, 16:33 Completed build in 10m 34s on Tue, 12 Nov, 04:33 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38309
-
Susi Moog uploaded patch set 3 11/13/19, 05:16
-
Susi Moog commented on patch set 3 V +1 CR +1 11/13/19, 05:17
TypoScriptFrontendController.php:1797Reply UnresolvedDidn't find a good reason for that as the TemplateService construct doesn't influence it. Moved it back down. -
TYPO3com voted on patch set 3 V -1 11/13/19, 05:23 Completed build in 07m 19s on Wed, 13 Nov, 05:23 AM Test Summary: 48219 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38321
-
TYPO3com voted on patch set 3 V +1 11/13/19, 06:50 Completed build in 1h 41m 28s on Wed, 13 Nov, 06:50 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38321
-
Daniel Gorges voted on patch set 3 V +1 CR +1 11/13/19, 07:41
-
Benni Mack voted on patch set 3 V +2 CR +2 11/13/19, 07:42
-
Benni Mack merged patch set 4 11/13/19, 07:42
TemplateService.php:376Unresolved