62306[TASK] Move page layout resolving into a separate class
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Guido Schmechel +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 912
-
Benni Mack uploaded patch set 1 11/12/19, 15:50
-
TYPO3com voted on patch set 1 V -1 11/12/19, 16:03 Completed build in 13m 24s on Tue, 12 Nov, 04:03 PM Test Summary: 12 of 47922 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38307
-
Benni Mack uploaded patch set 2 11/12/19, 16:05
-
TYPO3com voted on patch set 2 V +1 11/12/19, 16:19 Completed build in 14m 20s on Tue, 12 Nov, 04:19 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38308
-
Georg Ringer commented on patch set 2 11/12/19, 20:29
PageLayoutResolverTest.php:26aren't we using :void now there? -
Susi Moog uploaded patch set 3 11/13/19, 04:37
-
Susi Moog commented on patch set 3 11/13/19, 04:38
PageLayoutResolver.php:48ReplyDonePageLayoutResolverTest.php:26ReplyDone -
Susi Moog voted on patch set 3 V +1 CR +1 11/13/19, 04:38
-
TYPO3com voted on patch set 3 V +1 11/13/19, 04:59 Completed build in 21m 41s on Wed, 13 Nov, 04:59 AM Test Summary: 48318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38319
-
Guido Schmechel voted on patch set 3 CR +1 11/13/19, 08:05
-
Georg Ringer voted on patch set 3 V +2 CR +2 11/13/19, 08:37
-
Georg Ringer merged patch set 4 11/13/19, 08:37
PageLayoutResolver.php:48