Review main Merged

62306[TASK] Move page layout resolving into a separate class

Benni Mack CR +2 V +2 Normal +175 −33 updated 11/13/19, 08:37

Commit message

The functionality "getData = pagelayout" resolves the
selected backend layout for the current page, which is
used in TypoScript quite frequently.

In order to use this in e.g. TypoScript conditions, this
functionality is now extracted into a separate class,
and multiple unit tests are added.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 912

  1. Benni Mack uploaded patch set 1 11/12/19, 15:50

  2. TYPO3com voted on patch set 1 V -1 11/12/19, 16:03 Completed build in 13m 24s on Tue, 12 Nov, 04:03 PM Test Summary: 12 of 47922 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38307

  3. Benni Mack uploaded patch set 2 11/12/19, 16:05

  4. TYPO3com voted on patch set 2 V +1 11/12/19, 16:19 Completed build in 14m 20s on Tue, 12 Nov, 04:19 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38308

  5. Georg Ringer commented on patch set 2 11/12/19, 20:29

    PageLayoutResolver.php:48

    why not use an early return for that?

    PageLayoutResolverTest.php:26

    aren't we using :void now there?
  6. Susi Moog uploaded patch set 3 11/13/19, 04:37

  7. Susi Moog commented on patch set 3 11/13/19, 04:38

    PageLayoutResolver.php:48 Reply

    Done

    PageLayoutResolverTest.php:26 Reply

    Done
  8. Susi Moog voted on patch set 3 V +1 CR +1 11/13/19, 04:38

  9. TYPO3com voted on patch set 3 V +1 11/13/19, 04:59 Completed build in 21m 41s on Wed, 13 Nov, 04:59 AM Test Summary: 48318 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38319

  10. Guido Schmechel voted on patch set 3 CR +1 11/13/19, 08:05

  11. Georg Ringer voted on patch set 3 V +2 CR +2 11/13/19, 08:37

  12. Georg Ringer merged patch set 4 11/13/19, 08:37