62307[TASK] Instantiate log manager after service container
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1117
-
Alexander Schnitzler uploaded patch set 1 11/12/19, 16:42
-
TYPO3com voted on patch set 1 V -1 11/12/19, 16:45 Completed build in 02m 53s on Tue, 12 Nov, 04:45 PM Test Summary: 7613 of 48523 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38310
-
Alexander Schnitzler uploaded patch set 2 11/12/19, 16:53
-
TYPO3com voted on patch set 2 V -1 11/12/19, 17:01 Completed build in 07m 27s on Tue, 12 Nov, 05:01 PM Test Summary: 7613 of 48601 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38313
-
Alexander Schnitzler uploaded patch set 3 11/12/19, 17:11
-
Alexander Schnitzler uploaded patch set 4 11/12/19, 17:15
-
TYPO3com voted on patch set 4 V -1 11/12/19, 17:15 Completed build in 11s on Tue, 12 Nov, 05:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38315
-
TYPO3com voted on patch set 3 V -1 11/12/19, 17:18 Completed build in 06m 55s on Tue, 12 Nov, 05:18 PM Test Summary: 7062 of 48053 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38314
-
Alexander Schnitzler uploaded patch set 5 11/12/19, 17:25
-
TYPO3com voted on patch set 5 V +1 11/12/19, 17:33 Completed build in 08m 20s on Tue, 12 Nov, 05:33 PM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38316
-
Alexander Schnitzler uploaded patch set 6 11/13/19, 09:16
-
TYPO3com voted on patch set 6 V +1 11/13/19, 09:23 Completed build in 07m 14s on Wed, 13 Nov, 09:23 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38333
-
Alexander Schnitzler commented on patch set 6 11/13/19, 09:29
-
Helmut Hummel commented on patch set 6 11/14/19, 17:57
I totally get the need for DI for loggingUnresolved
With that, we would give up exceptions thrown during the DI container build being properly (nicely rendered) shown to developers. Also we would give up on warnings produced during this process to be converted to exceptions. To me both things wouldn't be desired. So a followup to this change should fix this.Bootstrap.php:145Unresolveddoesn't this mean, that GeneralUtility::makeInstance will provide a different LogManager object than when getting it injected with DI? Naively I'd do a $logManager = $container->get(LogManager::class) here instead. -
Helmut Hummel commented on patch set 6 CR -1 11/14/19, 17:58
-1 for now until questions are resolved. in general change makes sense to me -
Alexander Schnitzler commented on patch set 6 CR -2 11/15/19, 08:54
Unfortunately I found that while initializing the caches, the LogManager is also already needed and instantiated without the DI container. -
Alexander Schnitzler abandoned the change 11/23/19, 14:05
Abandoned due to new patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/62355)
Unresolved