Review main Merged

62309[TASK] Rename USER_INT related variables in TSFE

Benni Mack CR +2 V +2 Normal +38 −33 updated 11/14/19, 11:45

Commit message

The cryptic variables $INTiS_config and internal names are improved
by using "nonCacheable" as naming (everywhere where possible,
not modifying public API methods).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Johannes Schlier +1
    • Markus Klein +1
    • Daniel Gorges +1
    • Andreas Kienast +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1518

  1. Benni Mack uploaded patch set 1 11/13/19, 07:52

  2. TYPO3com voted on patch set 1 V +1 11/13/19, 08:00 Completed build in 08m 32s on Wed, 13 Nov, 08:00 AM Test Summary: 48296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38324

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/13/19, 08:38

  4. Markus Klein commented on patch set 1 CR -1 11/13/19, 10:16

    TypoScriptFrontendController.php:2947

    the paretheses are wrong IMO $this->additionalHeaderData = is_array($this->config['INTincScript_ext']['additionalHeaderData'] ?? false);
  5. Markus Klein commented on patch set 1 11/13/19, 10:19

    TypoScriptFrontendController.php:3055

    is this a hidden bugfix?
  6. Benni Mack commented on patch set 1 11/13/19, 10:21

    TypoScriptFrontendController.php:2947 Reply Unresolved

    thx. will fix.

    TypoScriptFrontendController.php:3055 Reply

    nope. I just split the ternery if into an elseif.
  7. Benni Mack uploaded patch set 2 11/13/19, 10:23

  8. TYPO3com voted on patch set 2 V -1 11/13/19, 10:32 Completed build in 08m 22s on Wed, 13 Nov, 10:32 AM Test Summary: 48088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38337

  9. TYPO3com voted on patch set 2 V +1 11/13/19, 10:48 Completed build in 33m 28s on Wed, 13 Nov, 10:48 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38337

  10. Markus Klein commented on patch set 2 11/13/19, 10:51

    TypoScriptFrontendController.php:3055 Reply

    Ack
  11. Markus Klein voted on patch set 2 CR +1 11/13/19, 10:51

  12. Susi Moog voted on patch set 2 CR +1 11/13/19, 10:52

  13. Susi Moog voted on patch set 2 V +1 11/13/19, 11:45

  14. Andreas Kienast voted on patch set 2 CR +1 11/13/19, 14:58

  15. Johannes Schlier voted on patch set 2 CR +1 11/13/19, 16:30

  16. Daniel Gorges voted on patch set 2 V +1 CR +1 11/14/19, 11:44

  17. Benni Mack voted on patch set 2 V +2 CR +2 11/14/19, 11:45

  18. Benni Mack merged patch set 3 11/14/19, 11:45