Review main Merged

62313[TASK] Re-order Frontend Content building process

Benni Mack CR +2 V +2 Normal +66 −59 updated 11/13/19, 13:14

Commit message

This patch streamlines the execution code when a base page is generated
by moving all logic into a few smaller methods to separate the actual
"cacheable page" logic from the PageRenderer population process,
and also adds more documentation to the methods.

In addition, some minor adjustments (site language is now
always available in v10) can be made, as some unnecessary
code execution (e.g. divSection assigment and unsetting
"JScode" explicitly) are made

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 811

  1. Benni Mack uploaded patch set 1 11/13/19, 09:09

  2. TYPO3com voted on patch set 1 V -1 11/13/19, 09:16 Completed build in 07m 45s on Wed, 13 Nov, 09:16 AM Test Summary: 52 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38332

  3. Susi Moog commented on patch set 1 11/13/19, 10:25

    RequestHandler.php:170 Unresolved

    is there a reason to use pageRenderer as an argument instead of calling getPageRenderer here?

    RequestHandler.php:214 Unresolved

    hasn't

    RequestHandler.php:226 Unresolved

    same question as above
  4. Susi Moog voted on patch set 1 V +1 11/13/19, 10:44

  5. Benni Mack uploaded patch set 2 11/13/19, 10:58

  6. TYPO3com voted on patch set 2 V -1 11/13/19, 10:58 Completed build in 16s on Wed, 13 Nov, 10:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38339

  7. Benni Mack uploaded patch set 3 11/13/19, 11:08

  8. TYPO3com voted on patch set 3 V +1 11/13/19, 11:18 Completed build in 08m 55s on Wed, 13 Nov, 11:18 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38340

  9. Susi Moog voted on patch set 3 V +1 CR +1 11/13/19, 11:50

  10. Georg Ringer voted on patch set 3 V +2 CR +2 11/13/19, 13:14

  11. Georg Ringer merged patch set 4 11/13/19, 13:14