Review main Merged

62314[BUGFIX] Fix PHP error in SoftReferenceParserHook for missing form definitions

Stephan Großberndt CR +2 V +2 Easy +5 −0 updated 11/21/19, 16:13

Commit message

This patch adds a safe guard to make sure the `$file` object is not null
on trying to update the soft reference. This is necessary as
`ResourceFactory->retrieveFileOrFolderObject()` returns null instead of
throwing an exception in several cases (e.g. missing form definition
located in an extension).

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Oliver Klee +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 610

  1. Stephan Großberndt uploaded patch set 1 11/13/19, 09:50

  2. TYPO3com voted on patch set 1 V -1 11/13/19, 09:58 Completed build in 07m 45s on Wed, 13 Nov, 09:58 AM Test Summary: 48088 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38334

  3. TYPO3com voted on patch set 1 V +1 11/13/19, 10:17 Completed build in 34m 36s on Wed, 13 Nov, 10:17 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38334

  4. Mathias Brodala uploaded patch set 2 11/21/19, 10:28

  5. Mathias Brodala commented on patch set 2 V +1 CR +1 11/21/19, 10:28

    Moved check out of the try..catch since that should only contain the bare minimum of code which could throw an exception. Also rebased to master.
  6. TYPO3com voted on patch set 2 V -1 11/21/19, 10:35 Completed build in 07m 12s on Thu, 21 Nov, 10:35 AM Test Summary: 48343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38525

  7. Oliver Klee voted on patch set 2 CR +1 11/21/19, 12:22

  8. TYPO3com voted on patch set 2 V +1 11/21/19, 13:55 Completed build in 07m 10s on Thu, 21 Nov, 01:55 PM Test Summary: 48061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38551

  9. Ralf Zimmermann voted on patch set 2 V +2 CR +2 11/21/19, 16:12

  10. Ralf Zimmermann merged patch set 3 11/21/19, 16:13