62317[TASK] Deprecate Extbase's WebRequest and WebResponse
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Jörg Bösche +1
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89673-DeprecateExtbasesWebRequestAndWebResponse.rstnew+45 −0
- typo3/sysext/extbase/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+18 −34
- typo3/sysext/extbase/Classes/Mvc/View/JsonView.php+14 −17
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php+2 −3
- typo3/sysext/extbase/Classes/Mvc/Web/Request.php+1 −109
- typo3/sysext/extbase/Classes/Mvc/Web/Response.php+1 −290
- typo3/sysext/extbase/Classes/Mvc/Request.php2+109 −0
- typo3/sysext/extbase/Classes/Mvc/Response.php2+292 −0
- typo3/sysext/fluid/Classes/Core/Widget/WidgetRequest.php+6 −1
- typo3/sysext/fluid/Classes/View/StandaloneView.php2+3 −4
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+2 −16
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php2+2 −2
Review log 1421
-
Alexander Schnitzler uploaded patch set 1 11/13/19, 11:58
-
TYPO3com voted on patch set 1 V -1 11/13/19, 14:12 Completed build in 18m 51s on Wed, 13 Nov, 02:12 PM Test Summary: 4 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38344
-
Alexander Schnitzler uploaded patch set 2 11/13/19, 16:42
-
TYPO3com voted on patch set 2 V -1 11/13/19, 16:50 Completed build in 07m 55s on Wed, 13 Nov, 04:50 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38345
-
TYPO3com voted on patch set 2 V +1 11/13/19, 16:52 Completed build in 17m 32s on Wed, 13 Nov, 04:52 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38345
-
Alexander Schnitzler uploaded patch set 3 11/13/19, 18:03
-
TYPO3com voted on patch set 3 V -1 11/13/19, 18:11 Completed build in 07m 06s on Wed, 13 Nov, 06:11 PM Test Summary: 48076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38346
-
TYPO3com voted on patch set 3 V +1 11/13/19, 18:20 Completed build in 23m 44s on Wed, 13 Nov, 06:20 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38346
-
Alexander Schnitzler commented on patch set 3 11/13/19, 18:25
This change is ready for review. -
Alexander Schnitzler commented on patch set 3 11/23/19, 14:01
ping -
Mathias Brodala commented on patch set 3 V +1 CR +1 11/23/19, 21:04
Verified through the "Backend users" module. -
Jörg Bösche commented on patch set 3 CR -1 11/25/19, 15:46
Request.php:552What is about strict return types for all methods of this class?Response.php:201Strict return types are missing. Please add to all new methods.StandaloneView.php:63Please import the fqdn.AdministrationController.php:190Import the fqdn. -
Alexander Schnitzler commented on patch set 3 11/26/19, 09:35
Request.php:552ReplyWould be possibly breaking for people. I copied all the logic from Web/Request.php into this class and it should not be altered to not change the public api.Response.php:201ReplySame answer like for the requested changes on the Request object.StandaloneView.php:63Reply UnresolvedI intentionally didn't use a FQCN here to make visible that the deprecated request is used here. When having to look at the use statements to identify the exact class used, it's non-intuitive imo.AdministrationController.php:190ReplyYes, makes sense in this class as there is only \TYPO3\CMS\Extbase\Mvc\Request used. -
Alexander Schnitzler uploaded patch set 4 11/26/19, 09:35
-
Alexander Schnitzler wrote 11/26/19, 09:35
Topic set to extbase -
TYPO3com voted on patch set 4 V -1 11/26/19, 09:42 Completed build in 07m 20s on Tue, 26 Nov, 09:42 AM Test Summary: 47915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38835
-
TYPO3com voted on patch set 4 V +1 11/26/19, 09:46 Completed build in 18m 02s on Tue, 26 Nov, 09:46 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38835
-
Jörg Bösche voted on patch set 4 CR +1 12/01/19, 19:10
-
Susi Moog voted on patch set 4 V +1 CR +1 12/06/19, 08:06
-
Daniel Goerz voted on patch set 4 V +2 CR +2 12/06/19, 20:32
-
Daniel Goerz merged patch set 5 12/06/19, 20:32