Review main Merged

62317[TASK] Deprecate Extbase's WebRequest and WebResponse

Alexander Schnitzler CR +2 V +2 Hard +496 −477 updated 12/06/19, 20:32

Commit message

In order to simplify the request/response handling in
Extbase and to prepare the introduction of PSR-7 compatible
request and response objects, the web versions of Extbase's
request and response have been deprecated. All relevant
logic has been moved into the base classes to stay api
compatible and not introduce a breaking change.

Along with the simplification of the request and response
objects, quite a lot of instance checks have been removed
to ease the transition to having a public api that is
defined by interfaces and not concrete implementations.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1421

  1. Alexander Schnitzler uploaded patch set 1 11/13/19, 11:58

  2. TYPO3com voted on patch set 1 V -1 11/13/19, 14:12 Completed build in 18m 51s on Wed, 13 Nov, 02:12 PM Test Summary: 4 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38344

  3. Alexander Schnitzler uploaded patch set 2 11/13/19, 16:42

  4. TYPO3com voted on patch set 2 V -1 11/13/19, 16:50 Completed build in 07m 55s on Wed, 13 Nov, 04:50 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38345

  5. TYPO3com voted on patch set 2 V +1 11/13/19, 16:52 Completed build in 17m 32s on Wed, 13 Nov, 04:52 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38345

  6. Alexander Schnitzler uploaded patch set 3 11/13/19, 18:03

  7. TYPO3com voted on patch set 3 V -1 11/13/19, 18:11 Completed build in 07m 06s on Wed, 13 Nov, 06:11 PM Test Summary: 48076 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38346

  8. TYPO3com voted on patch set 3 V +1 11/13/19, 18:20 Completed build in 23m 44s on Wed, 13 Nov, 06:20 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38346

  9. Alexander Schnitzler commented on patch set 3 11/13/19, 18:25

    This change is ready for review.
  10. Alexander Schnitzler commented on patch set 3 11/23/19, 14:01

    ping
  11. Mathias Brodala commented on patch set 3 V +1 CR +1 11/23/19, 21:04

    Verified through the "Backend users" module.
  12. Jörg Bösche commented on patch set 3 CR -1 11/25/19, 15:46

    Request.php:552

    What is about strict return types for all methods of this class?

    Response.php:201

    Strict return types are missing. Please add to all new methods.

    StandaloneView.php:63

    Please import the fqdn.

    AdministrationController.php:190

    Import the fqdn.
  13. Alexander Schnitzler commented on patch set 3 11/26/19, 09:35

    Request.php:552 Reply

    Would be possibly breaking for people. I copied all the logic from Web/Request.php into this class and it should not be altered to not change the public api.

    Response.php:201 Reply

    Same answer like for the requested changes on the Request object.

    StandaloneView.php:63 Reply Unresolved

    I intentionally didn't use a FQCN here to make visible that the deprecated request is used here. When having to look at the use statements to identify the exact class used, it's non-intuitive imo.

    AdministrationController.php:190 Reply

    Yes, makes sense in this class as there is only \TYPO3\CMS\Extbase\Mvc\Request used.
  14. Alexander Schnitzler uploaded patch set 4 11/26/19, 09:35

  15. Alexander Schnitzler wrote 11/26/19, 09:35

    Topic set to extbase
  16. TYPO3com voted on patch set 4 V -1 11/26/19, 09:42 Completed build in 07m 20s on Tue, 26 Nov, 09:42 AM Test Summary: 47915 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38835

  17. TYPO3com voted on patch set 4 V +1 11/26/19, 09:46 Completed build in 18m 02s on Tue, 26 Nov, 09:46 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38835

  18. Jörg Bösche voted on patch set 4 CR +1 12/01/19, 19:10

  19. Susi Moog voted on patch set 4 V +1 CR +1 12/06/19, 08:06

  20. Daniel Goerz voted on patch set 4 V +2 CR +2 12/06/19, 20:32

  21. Daniel Goerz merged patch set 5 12/06/19, 20:32