Review main Abandoned

62318[WIP][FEATURE] Introduce FLUIDPAGE frontend page generation

Benni Mack CR 0 V 0 Expert +1132 −894 updated 10/20/21, 09:10

Commit message

In recent TYPO3 versions, the concepts of dataProcessors
(= preprocess and prepare data delivered to the view) and FLUID-based
content elements have become very popular.

Now, in order to give integrators a more flexible way to have
control of a full page, the full page content generation is moved
into a custom class, which now can have "PAGE" or "FLUIDPAGE".

This is now possible to have full control over the delivered contents:

page = FLUIDPAGE
page.templateRootPaths.10 = EXT:myextension/Resources/Private/Pages/Templates
page.layoutRootPaths.10 = EXT:myextension/Resources/Private/Pages/Layouts
page.variables.pages = 123
page.dataProcessors.20 = MenuProcessor...

When going the "FLUIDPAGE" way, all the TypoScript options like includeCSS
and includeJS are not applied anymore - for consistency reasons in order
to have Fluid-lovers to use Fluid as much as possible.

Still open and ToDo:
- Add tests
- Implement data processors
- Test uncached handling WITHIN fluid
- Restrucute PageRenderer to have a string as template, and get rid of some old dust, ensure that the Template Files do not contain markers anymore
- Possibly add ViewHelpers for adding JS/CSS/Resources/MetaTags
- Cache response object in cache_pages and work with response/stream instead of TSFE->content
- Introduce .format or .contentType option to automatically apply this to the response object directly.
- Move adding headers to the building functionality of a PageGenerator
- Find a cool way to render content in a usable way. ContentDataProcessor?

Review

  • Code review CR 0
  • Verified V 0

Files 8

Review log 811

  1. Benni Mack uploaded patch set 1 11/13/19, 13:45

  2. Benni Mack updated the commit message in patch set 2 11/13/19, 13:46

  3. TYPO3com voted on patch set 1 V -1 11/13/19, 14:02 Completed build in 16m 27s on Wed, 13 Nov, 02:02 PM Test Summary: 84 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38342

  4. TYPO3com voted on patch set 2 V -1 11/13/19, 14:06 Completed build in 19m 20s on Wed, 13 Nov, 02:05 PM Test Summary: 84 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38343

  5. Mathias Brodala commented on patch set 2 11/15/19, 08:41

    Unresolved

    We should either suggest a different name or provide a solution to detect TypoScript modifications which assume "page" is a "PAGE" object. Otherwise it will become quite hard to debug why some extension is not working properly simply because things like "includeCSS" are not applied.
  6. Benni Mack commented on patch set 2 01/18/20, 18:21

    There are a couple of things to do before this change can be continued / discussed to be continued: - I really feel bad for "PageRenderer" - it is wrong on so many levels. It's another god class, and we should avoid doing this. - The order of cached/uncached content / PageRenderer is heavy and needs work - Keeping cached data within TSFE has a lot of legacy debt, I propose to use streams instead of $TSFE->content, and to cache this, plus all "USER_INT" info separately - Let's split up PageRenderer. I guess the next step for me is to introduce AssetCollector which takes off some load of PageRenderer.
  7. Benni Mack abandoned the change 01/18/20, 18:43

  8. Georg Ringer restored the change 02/02/21, 22:52

  9. Georg Ringer uploaded patch set 3 02/02/21, 22:53

  10. TYPO3com voted on patch set 3 V -1 02/02/21, 22:54 Completed build in 52s on Tue, 2 Feb, 10:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9206

  11. Benni Mack abandoned the change 10/20/21, 09:10

    I will abandon this change - again - unfortunately we still don't have a good solution to handle the USER_INT cases in corporation with Fluid Engine.