62318[WIP][FEATURE] Introduce FLUIDPAGE frontend page generation
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 8
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+19 −11
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+7 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+13 −882
- typo3/sysext/frontend/Classes/Page/DefaultPageGenerator.phpnew+942 −0
- typo3/sysext/frontend/Classes/Page/FluidPageGenerator.phpnew+114 −0
- typo3/sysext/frontend/Resources/Private/Pages/Layouts/Default.htmlnew+30 −0
- typo3/sysext/frontend/Resources/Private/Pages/Templates/Default.htmlnew+6 −0
Review log 811
-
Benni Mack uploaded patch set 1 11/13/19, 13:45
-
Benni Mack updated the commit message in patch set 2 11/13/19, 13:46
-
TYPO3com voted on patch set 1 V -1 11/13/19, 14:02 Completed build in 16m 27s on Wed, 13 Nov, 02:02 PM Test Summary: 84 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38342
-
TYPO3com voted on patch set 2 V -1 11/13/19, 14:06 Completed build in 19m 20s on Wed, 13 Nov, 02:05 PM Test Summary: 84 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38343
-
Mathias Brodala commented on patch set 2 11/15/19, 08:41
-
Benni Mack commented on patch set 2 01/18/20, 18:21
There are a couple of things to do before this change can be continued / discussed to be continued: - I really feel bad for "PageRenderer" - it is wrong on so many levels. It's another god class, and we should avoid doing this. - The order of cached/uncached content / PageRenderer is heavy and needs work - Keeping cached data within TSFE has a lot of legacy debt, I propose to use streams instead of $TSFE->content, and to cache this, plus all "USER_INT" info separately - Let's split up PageRenderer. I guess the next step for me is to introduce AssetCollector which takes off some load of PageRenderer. -
Benni Mack abandoned the change 01/18/20, 18:43
-
Georg Ringer restored the change 02/02/21, 22:52
-
Georg Ringer uploaded patch set 3 02/02/21, 22:53
-
TYPO3com voted on patch set 3 V -1 02/02/21, 22:54 Completed build in 52s on Tue, 2 Feb, 10:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9206
-
Benni Mack abandoned the change 10/20/21, 09:10
I will abandon this change - again - unfortunately we still don't have a good solution to handle the USER_INT cases in corporation with Fluid Engine.
Unresolved