Review main Merged

62319[DOCS] Fix minor typos in form documentation

Chris Müller CR +2 V +2 Easy +14 −14 updated 11/14/19, 09:11

Commit message

Some typos are fixed. Additionally the spelling of "customise" was
adjusted to en-us.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • Sybille Peters +1
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • Sybille Peters +1
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1114

  1. Chris Müller uploaded patch set 1 11/13/19, 18:39

  2. TYPO3com voted on patch set 1 V +1 11/13/19, 18:47 Completed build in 07m 15s on Wed, 13 Nov, 06:47 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38347

  3. Oli Bartsch commented on patch set 1 11/13/19, 19:53

    PropertyGridEditor.rst:107

    I think this is the same typo as in the other files. Don't think we need a `then` here. Same applies for Line:131
  4. Sybille Peters commented on patch set 1 11/14/19, 01:10

    The corrections look good.

    PropertyGridEditor.rst:107 Reply

    suggestion: "Set this to 'false' to disable the 'add new row' button.

    PropertyGridEditor.rst:131 Unresolved

    suggestion: "Set this to 'false' to disable the 'delete row' button.
  5. Björn Jacob commented on patch set 2 11/14/19, 07:06

    Published edit on patch set 1.
  6. Björn Jacob updated the commit message in patch set 3 11/14/19, 07:07

  7. Björn Jacob commented on patch set 3 V +1 CR +1 11/14/19, 07:09

    Should also be backported to v9.

    PropertyGridEditor.rst:107 Reply Unresolved

    I think the "then" can be removed. But I would keep the style with the "if sentences". There are many more in the docs with this structure. Is it okay for you?
  8. TYPO3com voted on patch set 2 V -1 11/14/19, 07:15 Completed build in 09m 35s on Thu, 14 Nov, 07:15 AM Test Summary: 1 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38359

  9. TYPO3com voted on patch set 3 V +1 11/14/19, 07:19 Completed build in 08m 42s on Thu, 14 Nov, 07:19 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38360

  10. Michael Telgkamp voted on patch set 3 V +1 CR +1 11/14/19, 07:26

  11. Sybille Peters voted on patch set 3 V +1 CR +1 11/14/19, 08:02

  12. Oli Bartsch voted on patch set 3 V +1 CR +1 11/14/19, 08:19

  13. Daniel Goerz voted on patch set 3 V +2 CR +2 11/14/19, 09:11

  14. Daniel Goerz merged patch set 4 11/14/19, 09:11