62319[DOCS] Fix minor typos in form documentation
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Björn Jacob +1
- Sybille Peters +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Björn Jacob +1
- Sybille Peters +1
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/form/Documentation/I/Concepts/Configuration/Index.rst+1 −1
- typo3/sysext/form/Documentation/I/Concepts/Finishers/Index.rst+1 −1
- typo3/sysext/form/Documentation/I/Config/proto/finishersDefinition/finishers/SaveToDatabase.rst+2 −2
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formEditor/inspectorEditors/PropertyGridEditor.rst4+9 −9
- typo3/sysext/form/Documentation/Introduction/Index.rst+1 −1
Review log 1114
-
Chris Müller uploaded patch set 1 11/13/19, 18:39
-
TYPO3com voted on patch set 1 V +1 11/13/19, 18:47 Completed build in 07m 15s on Wed, 13 Nov, 06:47 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38347
-
Oli Bartsch commented on patch set 1 11/13/19, 19:53
-
Sybille Peters commented on patch set 1 11/14/19, 01:10
The corrections look good.PropertyGridEditor.rst:107Replysuggestion: "Set this to 'false' to disable the 'add new row' button.PropertyGridEditor.rst:131Unresolvedsuggestion: "Set this to 'false' to disable the 'delete row' button. -
Björn Jacob commented on patch set 2 11/14/19, 07:06
Published edit on patch set 1. -
Björn Jacob updated the commit message in patch set 3 11/14/19, 07:07
-
Björn Jacob commented on patch set 3 V +1 CR +1 11/14/19, 07:09
Should also be backported to v9.PropertyGridEditor.rst:107Reply UnresolvedI think the "then" can be removed. But I would keep the style with the "if sentences". There are many more in the docs with this structure. Is it okay for you? -
TYPO3com voted on patch set 2 V -1 11/14/19, 07:15 Completed build in 09m 35s on Thu, 14 Nov, 07:15 AM Test Summary: 1 of 48679 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38359
-
TYPO3com voted on patch set 3 V +1 11/14/19, 07:19 Completed build in 08m 42s on Thu, 14 Nov, 07:19 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38360
-
Michael Telgkamp voted on patch set 3 V +1 CR +1 11/14/19, 07:26
-
Sybille Peters voted on patch set 3 V +1 CR +1 11/14/19, 08:02
-
Oli Bartsch voted on patch set 3 V +1 CR +1 11/14/19, 08:19
-
Daniel Goerz voted on patch set 3 V +2 CR +2 11/14/19, 09:11
-
Daniel Goerz merged patch set 4 11/14/19, 09:11
PropertyGridEditor.rst:107