62330[TASK] LogManager related test
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 4
Review log 79
-
Alexander Schnitzler uploaded patch set 1 11/15/19, 10:52
-
TYPO3com voted on patch set 1 V +1 11/15/19, 10:59 Completed build in 07m 11s on Fri, 15 Nov, 10:59 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38383
-
Alexander Schnitzler uploaded patch set 2 11/15/19, 11:07
-
TYPO3com voted on patch set 2 V +1 11/15/19, 11:17 Completed build in 09m 17s on Fri, 15 Nov, 11:17 AM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38386
-
Alexander Schnitzler commented on patch set 2 11/15/19, 11:41
Hi Helmut, Hi Benjamin, I'd like to know your opinion on this patch in contrast to my former one here https://review.typo3.org/c/Packages/TYPO3.CMS/+/62307 -
Alexander Schnitzler marked it work in progress 11/15/19, 11:41
-
Helmut Hummel commented on patch set 2 CR +1 11/15/19, 16:34
Looks good to me, thanksAbstractBackend.php:23why should this be internal now? -
Alexander Schnitzler commented on patch set 2 11/15/19, 20:46
This change is ready for review.AbstractBackend.php:23Reply UnresolvedIt's something we can discuss. I think it's problematic to open abstract classes, whose functionality is made for the cache backends of the core, to the public. It's not that peiple can't use it but the api is the Interface, not this class. We should stress this to enable us to change internals in this class, even in a breaking way without the need to take care of the users. The change in this patchset is not really invasive but this is such a low level class, I wouldn't open it to the public which leads to instanceof AbstractBackend checks in the worst case. -
Alexander Schnitzler abandoned the change 11/23/19, 14:05
Abandoned due to new patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/62355)