Review main Merged

62331[FEATURE] Migrate various Signal Slots to PSR-14 events

Benni Mack CR +2 V +2 Expert +984 −376 updated 11/25/19, 10:42

Commit message

This change migrates existing Extbase Signal Slots in EXT:core
to the new PSR-14 events, which allow to define a proper API
for each event fired.

The following new Events are in place:
- TYPO3\CMS\Core\Imaging\Event\ModifyIconForResourcePropertiesEvent
- TYPO3\CMS\Core\DataHandling\Event\IsTableExcludedFromReferenceIndexEvent
- TYPO3\CMS\Core\DataHandling\Event\AppendLinkHandlerElementsEvent
- TYPO3\CMS\Core\Configuration\Event\AfterTcaCompilationEvent
- TYPO3\CMS\Core\Database\Event\AlterTableDefinitionStatementsEvent
- TYPO3\CMS\Core\Tree\Event\ModifyTreeDataEvent

The following signals are now deprecated:
- TYPO3\CMS\Core\Imaging\IconFactory::buildIconForResourceSignal
- TYPO3\CMS\Core\Database\SoftReferenceIndex::setTypoLinkPartsElement
- TYPO3\CMS\Core\Database\ReferenceIndex::shouldExcludeTableFromReferenceIndex
- TYPO3\CMS\Core\Utility\ExtensionManagementUtility::tcaIsBeingBuilt
- TYPO3\CMS\Install\Service\SqlExpectedSchemaService::tablesDefinitionIsBeingBuilt
- TYPO3\CMS\Core\Tree\TableConfiguration\DatabaseTreeDataProvider::PostProcessTreeData

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 41

Show 21 more files

Review log 2650

Show 1225 earlier messages
  1. Benni Mack uploaded patch set 1 11/15/19, 20:09

  2. TYPO3com voted on patch set 1 V -1 11/15/19, 20:26 Completed build in 10m 35s on Fri, 15 Nov, 08:26 PM Test Summary: 6001 of 48601 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38404

  3. Benni Mack uploaded patch set 2 11/15/19, 20:56

  4. TYPO3com voted on patch set 2 V -1 11/15/19, 21:39 Completed build in 10m 49s on Fri, 15 Nov, 09:39 PM Test Summary: 4855 of 48601 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38407

  5. Benni Mack uploaded patch set 3 11/19/19, 13:10

  6. TYPO3com voted on patch set 3 V -1 11/19/19, 13:19 Completed build in 08m 36s on Tue, 19 Nov, 01:19 PM Test Summary: 83 of 48703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38478

  7. Benni Mack uploaded patch set 4 11/19/19, 15:23

  8. TYPO3com voted on patch set 4 V -1 11/19/19, 15:31 Completed build in 06m 59s on Tue, 19 Nov, 03:31 PM Test Summary: 23 of 48696 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38483

  9. TYPO3com commented on patch set 4 11/20/19, 09:44 Completed build in 18h 27m 32s on Wed, 20 Nov, 09:44 AM Test Summary: 23 of 48703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38483

  10. Benni Mack uploaded patch set 5 11/20/19, 09:44

  11. TYPO3com voted on patch set 5 V -1 11/20/19, 09:52 Completed build in 07m 28s on Wed, 20 Nov, 09:52 AM Test Summary: 3 of 48703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38496

  12. TYPO3com commented on patch set 5 11/20/19, 18:52 Completed build in 9h 14m 31s on Wed, 20 Nov, 06:52 PM Test Summary: 3 of 48703 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38496

  13. Benni Mack uploaded patch set 6 11/20/19, 19:15

  14. TYPO3com voted on patch set 6 V +1 11/20/19, 19:22 Completed build in 07m 05s on Wed, 20 Nov, 07:22 PM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38505

  15. Benjamin Franzke uploaded patch set 7 11/21/19, 18:21

  16. TYPO3com voted on patch set 7 V -1 11/21/19, 18:22 Completed build in 07s on Thu, 21 Nov, 06:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38567

  17. Benni Mack uploaded patch set 8 11/21/19, 21:35

  18. TYPO3com voted on patch set 8 V -1 11/21/19, 21:42 Completed build in 07m 40s on Thu, 21 Nov, 09:42 PM Test Summary: 17 of 48429 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38577

  19. Benni Mack uploaded patch set 9 11/21/19, 22:04

  20. TYPO3com voted on patch set 9 V +1 11/21/19, 22:37 Completed build in 25m 06s on Thu, 21 Nov, 10:37 PM Test Summary: 48084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38579

  21. Benjamin Franzke uploaded patch set 10 11/22/19, 06:27

  22. TYPO3com voted on patch set 10 V +1 11/22/19, 06:34 Completed build in 07m 26s on Fri, 22 Nov, 06:34 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38582

  23. Benni Mack uploaded patch set 11 11/22/19, 10:18

  24. Benni Mack uploaded patch set 12 11/22/19, 10:23

  25. TYPO3com voted on patch set 11 V -1 11/22/19, 10:26 Completed build in 07m 44s on Fri, 22 Nov, 10:26 AM Test Summary: 48084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38596

  1. TYPO3com voted on patch set 11 V +1 11/22/19, 10:29 Completed build in 18m 44s on Fri, 22 Nov, 10:29 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38596

  2. TYPO3com voted on patch set 12 V +1 11/22/19, 10:30 Completed build in 07m 16s on Fri, 22 Nov, 10:30 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38597

  3. Benni Mack rebased onto patch set 13 11/22/19, 11:33

  4. TYPO3com voted on patch set 13 V -1 11/22/19, 11:41 Completed build in 07m 40s on Fri, 22 Nov, 11:41 AM Test Summary: 47792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38616

  5. TYPO3com voted on patch set 13 V +1 11/22/19, 11:59 Completed build in 33m 38s on Fri, 22 Nov, 11:59 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38616

  6. TYPO3com commented on patch set 13 11/22/19, 12:06 Completed build in 11m 51s on Fri, 22 Nov, 12:06 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38619

  7. Daniel Goerz commented on patch set 13 11/22/19, 12:46

    Unresolved

    leading slash

    ReferenceIndex.php:169 Unresolved

    This looks ... odd

    SqlReader.php:49 Unresolved

    Can't we get rid of ?? GeneralUtility::makeInstance(PackageManager::class)

    SoftReferenceIndex.php:615

    Variable $elements is only needed inside the if block

    Deprecation-89733-SignalSlotsInCoreExtensionMigratedToPSR-14Events.rst:38 Unresolved

    determine

    Feature-89733-NewPSR-14EventsForExistingSignalSlotsInCoreExtension.rst:37 Unresolved

    define
  8. Benni Mack uploaded patch set 14 11/22/19, 13:00

  9. Benni Mack commented on patch set 14 11/22/19, 13:02

    SoftReferenceIndex.php:615 Reply

    nope. it's passed by reference INTO the method. Best pieces of code in Core!
  10. Benni Mack uploaded patch set 15 11/22/19, 13:04

  11. TYPO3com voted on patch set 14 V -1 11/22/19, 13:08 Completed build in 07m 38s on Fri, 22 Nov, 01:08 PM Test Summary: 285 of 48432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38630

  12. TYPO3com voted on patch set 15 V -1 11/22/19, 13:11 Completed build in 07m 04s on Fri, 22 Nov, 01:11 PM Test Summary: 282 of 48180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38631

  13. Benni Mack uploaded patch set 16 11/22/19, 13:18

  14. Daniel Goerz commented on patch set 16 11/22/19, 13:21

    SoftReferenceIndex.php:615 Reply

    Ack
  15. TYPO3com voted on patch set 16 V -1 11/22/19, 13:26 Completed build in 07m 38s on Fri, 22 Nov, 01:26 PM Test Summary: 225 of 48179 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38632

  16. Benni Mack uploaded patch set 17 11/22/19, 13:41

  17. TYPO3com voted on patch set 17 V -1 11/22/19, 13:49 Completed build in 07m 28s on Fri, 22 Nov, 01:49 PM Test Summary: 77 of 48432 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38636

  18. Benni Mack uploaded patch set 18 11/22/19, 14:14

  19. TYPO3com voted on patch set 18 V -1 11/22/19, 14:21 Completed build in 07m 03s on Fri, 22 Nov, 02:21 PM Test Summary: 54 of 48180 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38642

  20. Benni Mack uploaded patch set 19 11/22/19, 14:58

  21. TYPO3com voted on patch set 19 V +1 11/22/19, 15:06 Completed build in 07m 54s on Fri, 22 Nov, 03:06 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38647

  22. Susi Moog voted on patch set 19 V +1 CR +1 11/22/19, 16:11

  23. Daniel Goerz voted on patch set 19 V +2 CR +2 11/22/19, 16:18

  24. Daniel Goerz merged patch set 20 11/22/19, 16:18

  25. Benjamin Franzke commented on patch set 20 11/25/19, 10:42

    SqlReader.php:45 Unresolved

    This change causes upgrade wizards to fail, as UpgradeWiardsService::getBlockingDatabaseAdds() needs SqlReader and SqlReader requires symfony DI (now). Symfony DI is not (yet) available in upgrade wizards, and as such already caused some problems (so that needs to be fixed anyway), but now the upgrade wizards will always fail. Please see following patch for an attempt to fix this situation: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62425