Review main Merged

62333[TASK] Add Maori locale and flag

Simon Gilli CR +2 V +2 Easy +5 −2 updated 11/17/19, 09:55

Commit message

This patch adds the locale Maori and it's flag for New Zealand.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1825

  1. Simon Gilli uploaded patch set 1 11/16/19, 11:48

  2. Riccardo De Contardi commented on patch set 1 V +1 11/16/19, 11:55

    Tested with latest master added new language > flag is visible and selectable
  3. TYPO3com voted on patch set 1 V +1 11/16/19, 11:56 Completed build in 07m 24s on Sat, 16 Nov, 11:56 AM Test Summary: 48319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38413

  4. Benni Mack commented on patch set 1 CR -1 11/16/19, 12:37

    IconRegistry.php:828

    "MI" is not special
  5. Simon Gilli commented on patch set 1 11/16/19, 12:46

    IconRegistry.php:828 Reply

    Thanks, was not sure about this
  6. Simon Gilli uploaded patch set 2 11/16/19, 12:47

  7. TYPO3com voted on patch set 2 V +1 11/16/19, 12:55 Completed build in 07m 52s on Sat, 16 Nov, 12:55 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38414

  8. Riccardo De Contardi commented on patch set 2 V +1 11/16/19, 16:31

    Tested with latest master added new language > flag is visible and selectable
  9. Chris Müller commented on patch set 2 V -1 11/16/19, 18:29

    When using the Maori language in site configuration, tab "Languages", field "Language Key for XLF Files" I don't have an entry for "Maori". And a small usability glitch: When creating a sys_language record, in the "select language" box the language is available as "Māori". This has two impacts: The word is not alphabetically sorted (it is after "Mongolian") and I can't jump to the language while typing "ma". I suggest to write "Maori" to make the usage easier, what do you think?
  10. Simon Gilli commented on patch set 2 11/16/19, 19:48

    > Patch Set 2: Verified-1 > > When using the Maori language in site configuration, tab "Languages", field "Language Key for XLF Files" I don't have an entry for "Maori". > > And a small usability glitch: When creating a sys_language record, in the "select language" box the language is available as "Māori". This has two impacts: The word is not alphabetically sorted (it is after "Mongolian") and I can't jump to the language while typing "ma". I suggest to write "Maori" to make the usage easier, what do you think? Thanks for this hint, the creator of this issue asked for the locale in this moment and I'm trying to handle this in this patch too. Will talk to him what he thinks about your suggestion...
  11. Simon Gilli uploaded patch set 3 11/16/19, 20:06

  12. TYPO3com voted on patch set 3 V +1 11/16/19, 20:14 Completed build in 08m 18s on Sat, 16 Nov, 08:14 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38425

  13. Simon Gilli uploaded patch set 4 11/16/19, 20:57

  14. TYPO3com voted on patch set 4 V +1 11/16/19, 21:05 Completed build in 07m 20s on Sat, 16 Nov, 09:05 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38427

  15. Tymoteusz Motylewski voted on patch set 4 CR +1 11/16/19, 21:39

  16. Tymoteusz Motylewski commented on patch set 4 11/16/19, 21:40

    not sure if it should go to v8 though
  17. Chris Müller voted on patch set 4 V +1 CR +1 11/16/19, 22:08

  18. Tymoteusz Motylewski updated the commit message in patch set 5 11/17/19, 08:03

  19. Tymoteusz Motylewski commented on patch set 5 V +1 CR +1 11/17/19, 08:04

    works, I've just removed 8.7 from releases as the backport is not straight and it is not a priority bugfix
  20. TYPO3com voted on patch set 5 V -1 11/17/19, 08:11 Completed build in 07m 43s on Sun, 17 Nov, 08:11 AM Test Summary: 1 of 48203 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38430

  21. TYPO3com commented on patch set 5 11/17/19, 09:30 Completed build in 1h 34m 44s on Sun, 17 Nov, 09:30 AM Test Summary: 1 of 48458 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38430

  22. TYPO3com voted on patch set 5 V +1 11/17/19, 09:32 Completed build in 3h 03m 47s on Sun, 17 Nov, 09:32 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38430

  23. Tymoteusz Motylewski commented on patch set 5 V +2 CR +2 11/17/19, 09:33

    Taking into account previous votes, just commit message was changed.
  24. Tymoteusz Motylewski merged patch set 6 11/17/19, 09:33

  25. Simon Gilli commented on patch set 6 11/17/19, 09:55

    > Patch Set 5: Verified+1 Code-Review+1 > > works, I've just removed 8.7 from releases as the backport is not straight and it is not a priority bugfix That's fine, thx for merging!