Review main Merged

62334[DOCS] Fix mistakes regarding RTE-configuration via TsConfig

TYPO3com CR +2 V +2 Easy +4 −7 updated 11/25/19, 06:48

Commit message

1. "Override for one table" is not implemented in core;
2. Preset "normal" is confusing / non-existing in core. Use
"myCustomPreset" to demonstrate usage of custom presets.
3. Use the same syntax (with square brackets) like in:
https://docs.typo3.org/m/typo3/reference-tsconfig/master/en-us/PageTsconfig/Rte.html

Review

  • Code review CR +2 Done
    • Daniel Siepmann +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Siepmann +2
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1117

  1. TYPO3com uploaded patch set 1 11/16/19, 21:17

  2. TYPO3com voted on patch set 1 V +1 11/16/19, 21:51 Completed build in 13m 03s on Sat, 16 Nov, 09:51 PM Test Summary: 48320 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38428

  3. Mathias Brodala updated the commit message in patch set 2 11/23/19, 21:15

  4. Mathias Brodala updated the commit message in patch set 3 11/23/19, 21:16

  5. Mathias Brodala voted on patch set 3 V +1 CR +1 11/23/19, 21:16

  6. TYPO3com voted on patch set 2 V +1 11/23/19, 21:22 Completed build in 06m 44s on Sat, 23 Nov, 09:22 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38786

  7. TYPO3com voted on patch set 3 V -1 11/23/19, 21:23 Completed build in 07m 27s on Sat, 23 Nov, 09:23 PM Test Summary: 47916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38787

  8. TYPO3com voted on patch set 3 V +1 11/23/19, 21:36 Completed build in 27m 43s on Sat, 23 Nov, 09:36 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38787

  9. Björn Jacob voted on patch set 3 V +1 CR +1 11/23/19, 22:09

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 11/24/19, 00:09

  11. Elias Häußler voted on patch set 3 V +1 CR +1 11/24/19, 10:13

  12. Daniel Goerz updated the commit message in patch set 4 11/24/19, 17:11

  13. TYPO3com voted on patch set 4 V +1 11/24/19, 17:19 Completed build in 07m 34s on Sun, 24 Nov, 05:19 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38800

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 11/24/19, 17:46

  15. Björn Jacob commented on patch set 4 V +1 CR +1 11/24/19, 18:03

    Thx Daniel for taking care :/ Should have seen this with the [DOCS] prefix ;)
  16. Daniel Siepmann voted on patch set 4 V +2 CR +2 11/25/19, 06:48

  17. Daniel Siepmann merged patch set 5 11/25/19, 06:48