Review main Merged

62336[BUGFIX] Ensures configuration for resolveAnchorLink is an array

Susi Moog CR +2 V +2 Easy +1 −1 updated 11/17/19, 18:49

Commit message

Strict typing requires $conf to be an array as parameter for
resolveAnchorLink, however it may also be null. The fix ensures that
on calling resolveAnchorLink a null coalescing operator ensures type
array.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 79

  1. Susi Moog uploaded patch set 1 11/17/19, 16:35

  2. TYPO3com voted on patch set 1 V -1 11/17/19, 16:44 Completed build in 08m 35s on Sun, 17 Nov, 04:44 PM Test Summary: 48092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38438

  3. TYPO3com voted on patch set 1 V +1 11/17/19, 16:51 Completed build in 23m 50s on Sun, 17 Nov, 04:51 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38438

  4. Simon Gilli voted on patch set 1 CR +1 11/17/19, 16:52

  5. Oliver Klee voted on patch set 1 CR +1 11/17/19, 17:08

  6. Oli Bartsch voted on patch set 1 CR +1 11/17/19, 17:11

  7. Daniel Goerz voted on patch set 1 V +1 CR +1 11/17/19, 17:24

  8. Georg Ringer voted on patch set 1 V +2 CR +2 11/17/19, 18:48

  9. Georg Ringer merged patch set 2 11/17/19, 18:49