Review main Merged

62338[FEATURE] Show Layouts in Info Module

Simon Gilli CR +2 V +2 Normal +94 −6 updated 06/09/21, 17:46

Commit message

This patch introduces a new type for the Pagetree overview
in the info module. It displays the relevant layout fields,
e.g. backend layout and frontent layout, next to an additional
field which contains the actually used backend layout, inherited
from a parent page.

This follows #94210, which already introduced a field information
for the pages.backend_layout field.

This effectively allows an editor to have a detailed overview of
the configured and - more importantly - actually used backend
layouts for a page or even a complete page tree.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 3547

Show 1522 earlier messages
  1. Simon Gilli uploaded patch set 1 11/18/19, 11:14

  2. Simon Gilli commented on patch set 1 11/18/19, 11:26

    Here we go...
  3. TYPO3com voted on patch set 1 V -1 11/18/19, 11:42 Completed build in 14m 04s on Mon, 18 Nov, 11:42 AM Test Summary: 1 of 48701 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38446

  4. TYPO3com voted on patch set 1 V +1 11/18/19, 12:59 Completed build in 1h 45m 27s on Mon, 18 Nov, 12:59 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38446

  5. Georg Ringer commented on patch set 1 11/18/19, 13:21

    I am not sure why we need this in core

    DefaultConfiguration.php:1227

    please use a proper label, no need to follow a stupid pseudo-rule
  6. Claus Due commented on patch set 1 11/18/19, 13:38

    Wording should be changed: the expression "an own XYZ" is not proper English and should be avoided everywhere; it's a common mistake made by German, Danish and other EU language speakers. In English this word basically means "possessed by" and does not mean "unique" or "discrete". Suggested wording: This patch adds backend layouts as discrete item in function menu of the web -> info module.
  7. Simon Gilli commented on patch set 1 11/19/19, 00:39

    > Patch Set 1: > > (1 comment) > > I am not sure why we need this in core see https://github.com/benjaminkott/bootstrap_package/pull/787#discussion_r347239791
  8. Simon Gilli commented on patch set 1 11/19/19, 00:41

    And thanks for the other comments, will do the changes tomorrow...
  9. Richard Haeser commented on patch set 1 11/19/19, 06:47

    DefaultConfiguration.php:1228

    Those fields without a title and uid is not helping me as an editor.

    Feature-89700-ShowBackendLayoutsInTheWebInfoModule.rst:19

    This is practically the same as in description. The impact is that (as it is an additional overview) it is not affecting existing installations and only gives a new overview.
  10. Simon Gilli uploaded patch set 2 11/19/19, 12:59

  11. Simon Gilli commented on patch set 2 11/19/19, 13:00

    Reply

    Done

    DefaultConfiguration.php:1227 Reply

    Done

    DefaultConfiguration.php:1228 Reply

    Done

    Feature-89700-ShowBackendLayoutsInTheWebInfoModule.rst:19 Reply

    Done
  12. Simon Gilli commented on patch set 2 11/19/19, 13:03

    locallang_webinfo.xlf:18

    I'm not sure if this drive by change is ok
  13. TYPO3com voted on patch set 2 V +1 11/19/19, 13:06 Completed build in 06m 54s on Tue, 19 Nov, 01:06 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38477

  14. Georg Ringer commented on patch set 2 11/19/19, 13:28

    locallang_webinfo.xlf:18 Reply

    I would avoid such stuff as there is absolutly no win and makes it harder to review your change. pls remove
  15. Simon Gilli commented on patch set 2 11/19/19, 13:40

    locallang_webinfo.xlf:18 Reply

    Ack
  16. Simon Gilli uploaded patch set 3 11/19/19, 13:41

  17. Simon Gilli uploaded patch set 4 11/19/19, 13:45

  18. Benni Mack commented on patch set 4 11/19/19, 13:49

    sounds like a "simple" change, but the most powerful thing is to actually use the "resolved" Backend Layout instead of a simple list of the database fields. I just abstracted this a week ago into PageLayoutResolver to be used in more places.
  19. TYPO3com voted on patch set 3 V +1 11/19/19, 13:49 Completed build in 07m 30s on Tue, 19 Nov, 01:49 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38480

  20. TYPO3com voted on patch set 4 V -1 11/19/19, 13:52 Completed build in 06m 47s on Tue, 19 Nov, 01:52 PM Test Summary: 1 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38481

  21. TYPO3com voted on patch set 4 V +1 11/19/19, 15:34 Completed build in 07m 12s on Tue, 19 Nov, 03:34 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38484

  22. TYPO3com commented on patch set 4 11/19/19, 15:40 Completed build in 07m 05s on Tue, 19 Nov, 03:40 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38485

  1. Georg Ringer commented on patch set 4 V -1 CR -1 11/21/19, 09:47

    See screenshot of current implementation in screenshot. If using records, the record uid is shown which is really not helpful at all. So instead of the identifier the label must be shown instead.
  2. Georg Ringer uploaded patch set 5 11/21/19, 10:35

  3. TYPO3com voted on patch set 5 V +1 11/21/19, 10:42 Completed build in 06m 59s on Thu, 21 Nov, 10:42 AM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38526

  4. Benni Mack uploaded patch set 6 02/14/20, 20:35

  5. TYPO3com voted on patch set 6 V +1 02/14/20, 21:50 Completed build in 22m 41s on Fri, 14 Feb, 09:50 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-93

  6. Benni Mack commented on patch set 6 02/15/20, 09:55

    Georg, could you add the identifier as well? Otherwise I think this change would be "ok"
  7. Georg Ringer commented on patch set 6 V -1 CR -1 02/15/20, 15:21

    sorry but this patch doesn't work. The value of the field "backend_layout_next_level" is not really evaluated. Given the page structure page | backend_layout | backend_layout_next_level Page 1 | Layout 1 | Layout 2 then for backend_layout_next_level the value of backend_layout is shown
  8. Benni Mack commented on patch set 6 02/27/20, 11:42

    I'm fine with abandoning this change then, seems to be more work (= also more DB requests) than necessary / for the benefit.
  9. Benni Mack abandoned the change 02/27/20, 21:31

    can be warmed up for v11 if wanted
  10. Oli Bartsch restored the change 06/04/21, 20:27

  11. Oli Bartsch uploaded patch set 7 06/04/21, 20:29

  12. core-ci voted on patch set 7 V +1 06/04/21, 20:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12169

  13. Oli Bartsch uploaded patch set 8 06/04/21, 23:02

  14. Oli Bartsch commented on patch set 8 06/04/21, 23:05

    Restored this patch as follow-up for #94210. It now displays the selected layouts from the page properties, next to an additional field, which shows the actually used backend layout for the page (based on the inherited backend_layout_next_level).
  15. core-ci voted on patch set 8 V +1 06/04/21, 23:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12171

  16. Jochen Roth voted on patch set 8 V +1 CR +1 06/08/21, 07:02

  17. Christian Kuhn commented on patch set 8 CR -1 06/08/21, 12:36

    on it.
  18. Christian Kuhn commented on patch set 8 06/09/21, 10:30

    talked to oli: he'll push a minor update.
  19. Oli Bartsch uploaded patch set 9 06/09/21, 14:57

  20. Oli Bartsch commented on patch set 9 06/09/21, 14:59

    Reply

    Done
  21. core-ci voted on patch set 9 V +1 06/09/21, 15:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12228

  22. Christian Kuhn voted on patch set 9 V +1 CR +1 06/09/21, 16:12

  23. Jochen Roth voted on patch set 9 V +1 CR +1 06/09/21, 17:17

  24. Richard Haeser voted on patch set 9 V +2 CR +2 06/09/21, 17:45

  25. Richard Haeser merged patch set 10 06/09/21, 17:46