62339[TASK] Update nikic/php-parser to ^4.3
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1217
-
Alexander Schnitzler uploaded patch set 1 11/18/19, 13:23
-
TYPO3com voted on patch set 1 V +1 11/18/19, 13:30 Completed build in 07m 08s on Mon, 18 Nov, 01:30 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38450
-
Alexander Schnitzler updated the commit message in patch set 2 11/18/19, 13:53
-
TYPO3com voted on patch set 2 V +1 11/18/19, 14:00 Completed build in 07m 07s on Mon, 18 Nov, 02:00 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38452
-
Georg Ringer voted on patch set 2 V +1 CR +1 11/18/19, 14:35
-
Andreas Kienast uploaded patch set 3 11/18/19, 15:53
-
Andreas Kienast commented on patch set 3 V +1 CR +1 11/18/19, 15:53
I've updated the composer.lock to get rid of the unnecessary changes. Alex, which composer version do you use? -
TYPO3com voted on patch set 3 V +1 11/18/19, 16:00 Completed build in 06m 53s on Mon, 18 Nov, 04:00 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38456
-
Oliver Klee commented on patch set 3 11/18/19, 18:03
composer.json:46Why ~ instead of ^? (And also, for brevity, "4.3" can be used instead of "4.3.0".) -
Alexander Schnitzler commented on patch set 3 11/19/19, 12:18
composer.json:46Reply UnresolvedI wasn't sure if that package follows semver. I'm ok with using the full range up the next major version. -
Oliver Klee commented on patch set 3 11/19/19, 12:21
According to https://github.com/nikic/PHP-Parser/blob/master/CHANGELOG.md, the release strategy seems to partially follow SemVer (removals only for major releases, although bugfix releases also add new features). -
Alexander Schnitzler uploaded patch set 4 11/19/19, 12:23
-
Oliver Klee voted on patch set 4 CR +1 11/19/19, 12:27
-
TYPO3com voted on patch set 4 V -1 11/19/19, 12:29 Completed build in 06m 22s on Tue, 19 Nov, 12:29 PM Test Summary: 7 of 48700 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38475
-
TYPO3com voted on patch set 4 V +1 11/19/19, 12:34 Completed build in 17m 07s on Tue, 19 Nov, 12:34 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38475
-
Benni Mack voted on patch set 4 V +2 CR +2 11/19/19, 12:46
-
Benni Mack merged patch set 5 11/19/19, 12:46