Review main Abandoned

62340[TASK] Update hostHeaderValueMatchesTrustedHostsPattern

TYPO3com CR 0 V 0 Easy +3 −1 updated 01/22/20, 14:49

Commit message

If we are behind a reverse proxy (that uses http connection to TYPO3 and
https to the client) and host header value includes port then check if:

$parsedHostValue['host'] equals strtolower($_SERVER['SERVER_NAME'])
and
(string)$parsedHostValue['port'] equals $defaultPort.

Otherwise SERVER_PORT equals Port 80 and parsedHostValue['port'] is
reporting NULL (or 443 when included in the header) and the check always
fails =>
- (string)$parsedHostValue['port']: 443 != $_SERVER['SERVER_PORT']: 80
- $defaultPort: 443 != $_SERVER['SERVER_PORT']: 80

My code might be utter trash so please check if it is secure.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 13

  1. TYPO3com uploaded patch set 1 11/18/19, 13:28

  2. TYPO3com voted on patch set 1 V -1 11/18/19, 13:36 Completed build in 07m 31s on Mon, 18 Nov, 01:36 PM Test Summary: 48 of 48700 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38451

  3. Susi Moog abandoned the change 01/22/20, 14:49

    see issue description