Review 9.5 Merged

62344[BUGFIX] Remove jumpToUrl function in LinkBrowser

Dennis Prinse CR +2 V +2 Easy +2 −8 updated 12/06/19, 11:43

Commit message

This patch backports the changes in AbstractLinkBrowserController
which were added in patch #89033.

Before, the AbstractLinkBrowserController added a href=#
and an onclick=jumpToUrl() which triggered JavaScript to switch
tabs. In this patch, the onclick=jumpToUrl() function will
be removed from a tab and complete url will be set to the tab
instead.

The onclick=jumpToUrl() function caused problems when switching
tabs while resources were loading.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 912

  1. Dennis Prinse uploaded patch set 1 11/19/19, 13:36

  2. TYPO3com voted on patch set 1 V +1 11/19/19, 13:45 Completed build in 09m 01s on Tue, 19 Nov, 01:45 PM Test Summary: 50966 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1533

  3. Andreas Kienast commented on patch set 1 CR -1 11/19/19, 15:46

    Hey. Can you please explain the benefit of this change for 9.5?
  4. Richard Haeser commented on patch set 1 11/27/19, 21:30

    Unresolved

    Can you update the commit message a little bit to tell what this patch will do? It is a backport but not a complete one. So the commit message can mainly tell what you have done here.
  5. Dennis Prinse updated the commit message in patch set 2 12/06/19, 10:45

  6. TYPO3com voted on patch set 2 V +1 12/06/19, 10:55 Completed build in 09m 54s on Fri, 6 Dec, 10:55 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1673

  7. Andreas Kienast updated the commit message in patch set 3 12/06/19, 11:24

  8. Andreas Kienast voted on patch set 3 V +1 CR +1 12/06/19, 11:24

  9. Richard Haeser commented on patch set 3 V +1 CR +1 12/06/19, 11:29

    Waiting for a positive review of bamboo before converting my review into a +2
  10. TYPO3com voted on patch set 3 V +1 12/06/19, 11:40 Completed build in 13m 25s on Fri, 6 Dec, 11:40 AM Test Summary: 71804 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1676

  11. Richard Haeser voted on patch set 3 V +2 CR +2 12/06/19, 11:43

  12. Richard Haeser merged patch set 4 12/06/19, 11:43