Review main Merged

62345[TASK] Do not use constants in low-level classes

Benni Mack CR +2 V +2 Easy +14 −14 updated 11/20/19, 14:19

Commit message

There are certain PHP classes used in the testing framework that
use constants like "LF" which are defined by the SystemEnvironmentBuilder.

The testing framework depends on these classes, but should not
depend on global constants like "LF". The patch changes the lines to "\n"
allowing to continue slimming down testing framework.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Alexander Schnitzler +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1722

  1. Benni Mack uploaded patch set 1 11/19/19, 15:43

  2. TYPO3com voted on patch set 1 V +1 11/19/19, 15:51 Completed build in 07m 08s on Tue, 19 Nov, 03:51 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38486

  3. Oliver Hader voted on patch set 1 V +1 CR +1 11/19/19, 15:51

  4. Oliver Klee commented on patch set 1 11/19/19, 17:30

    ConfigurationManager.php:374

    Would it make sense to merge those two concatenated strings so that the complete string uses double quotes? (This would allow us avoid the concatenation.)
  5. Alexander Schnitzler commented on patch set 1 11/19/19, 19:40

    ConfigurationManager.php:374 Reply

    We could also use HEREDOC syntax and avoid the definition of line breaks altogether: > $configuration = ArrayUtility::arrayExport($configuration); > > <<<CONTENT > <?php > return $configuration; > > CONTENT,
  6. Susi Moog uploaded patch set 2 11/20/19, 07:36

  7. TYPO3com voted on patch set 2 V -1 11/20/19, 07:36 Completed build in 11s on Wed, 20 Nov, 07:36 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38490

  8. Susi Moog uploaded patch set 3 11/20/19, 07:48

  9. Susi Moog commented on patch set 3 V +1 CR +1 11/20/19, 07:50

    ConfigurationManager.php:374 Reply

    I did as Oli suggested.
  10. TYPO3com voted on patch set 3 V -1 11/20/19, 07:55 Completed build in 06m 52s on Wed, 20 Nov, 07:55 AM Test Summary: 4 of 48700 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38491

  11. Susi Moog uploaded patch set 4 11/20/19, 08:09

  12. TYPO3com voted on patch set 4 V +1 11/20/19, 08:16 Completed build in 07m 06s on Wed, 20 Nov, 08:16 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38492

  13. Susi Moog voted on patch set 4 V +1 CR +1 11/20/19, 08:22

  14. Oliver Klee commented on patch set 4 11/20/19, 08:48

    ConfigurationManager.php:374 Reply

    Thanks! For some of the other changed lines, we should do the same edit. Should I do it, or would you like to do it?
  15. Benni Mack commented on patch set 4 11/20/19, 09:41

    ConfigurationManager.php:374 Reply Unresolved

    would be great if you could do it!
  16. Oliver Klee uploaded patch set 5 11/20/19, 13:44

  17. Oliver Klee voted on patch set 5 CR +1 11/20/19, 13:46

  18. TYPO3com voted on patch set 5 V +1 11/20/19, 13:51 Completed build in 06m 50s on Wed, 20 Nov, 01:51 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38498

  19. Alexander Schnitzler voted on patch set 5 V +1 CR +1 11/20/19, 13:54

  20. Benni Mack voted on patch set 5 V +1 CR +1 11/20/19, 14:09

  21. Susi Moog voted on patch set 5 V +2 CR +2 11/20/19, 14:19

  22. Susi Moog merged patch set 6 11/20/19, 14:19