62345[TASK] Do not use constants in low-level classes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Oliver Klee +1
- Alexander Schnitzler +1
- Benni Mack +1
-
Verified V +2 Done
- Susi Moog +2
- Alexander Schnitzler +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1722
-
Benni Mack uploaded patch set 1 11/19/19, 15:43
-
TYPO3com voted on patch set 1 V +1 11/19/19, 15:51 Completed build in 07m 08s on Tue, 19 Nov, 03:51 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38486
-
Oliver Hader voted on patch set 1 V +1 CR +1 11/19/19, 15:51
-
Oliver Klee commented on patch set 1 11/19/19, 17:30
-
Alexander Schnitzler commented on patch set 1 11/19/19, 19:40
ConfigurationManager.php:374ReplyWe could also use HEREDOC syntax and avoid the definition of line breaks altogether: > $configuration = ArrayUtility::arrayExport($configuration); > > <<<CONTENT > <?php > return $configuration; > > CONTENT, -
Susi Moog uploaded patch set 2 11/20/19, 07:36
-
TYPO3com voted on patch set 2 V -1 11/20/19, 07:36 Completed build in 11s on Wed, 20 Nov, 07:36 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38490
-
Susi Moog uploaded patch set 3 11/20/19, 07:48
-
Susi Moog commented on patch set 3 V +1 CR +1 11/20/19, 07:50
ConfigurationManager.php:374ReplyI did as Oli suggested. -
TYPO3com voted on patch set 3 V -1 11/20/19, 07:55 Completed build in 06m 52s on Wed, 20 Nov, 07:55 AM Test Summary: 4 of 48700 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38491
-
Susi Moog uploaded patch set 4 11/20/19, 08:09
-
TYPO3com voted on patch set 4 V +1 11/20/19, 08:16 Completed build in 07m 06s on Wed, 20 Nov, 08:16 AM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38492
-
Susi Moog voted on patch set 4 V +1 CR +1 11/20/19, 08:22
-
Oliver Klee commented on patch set 4 11/20/19, 08:48
ConfigurationManager.php:374ReplyThanks! For some of the other changed lines, we should do the same edit. Should I do it, or would you like to do it? -
Benni Mack commented on patch set 4 11/20/19, 09:41
ConfigurationManager.php:374Reply Unresolvedwould be great if you could do it! -
Oliver Klee uploaded patch set 5 11/20/19, 13:44
-
Oliver Klee voted on patch set 5 CR +1 11/20/19, 13:46
-
TYPO3com voted on patch set 5 V +1 11/20/19, 13:51 Completed build in 06m 50s on Wed, 20 Nov, 01:51 PM Test Summary: 48344 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38498
-
Alexander Schnitzler voted on patch set 5 V +1 CR +1 11/20/19, 13:54
-
Benni Mack voted on patch set 5 V +1 CR +1 11/20/19, 14:09
-
Susi Moog voted on patch set 5 V +2 CR +2 11/20/19, 14:19
-
Susi Moog merged patch set 6 11/20/19, 14:19
ConfigurationManager.php:374