Review 9.5 Merged

62346[BUGFIX] Synchronize TCA enable columns from workspace version

Benni Mack CR +2 V +2 Hard +300 −41 updated 11/20/19, 16:28

Commit message

In case workspace placeholders (new or move) are involved corresponding
explicit TCA control settings in either shadowColumnsForMovePlaceholders
or shadowColumnsForNewPlaceholders are used to update those field values
and synchronize workspace versions with their placeholder records.

Since the data-retrieval process first queries live version pendants and
then tries to overlay those records with version information, values for
enable columns shall be synchronized automatically - otherwise possible
HiddenRestriction or StartTimeRestriction would deny selecting live
versions already in the first place.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 46

  1. Benni Mack uploaded patch set 1 11/20/19, 15:41

  2. Achim Fritz voted on patch set 1 V +1 CR +1 11/20/19, 15:48

  3. TYPO3com voted on patch set 1 V -1 11/20/19, 15:53 Completed build in 12m 03s on Wed, 20 Nov, 03:53 PM Test Summary: 50660 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1538

  4. TYPO3com voted on patch set 1 V +1 11/20/19, 16:27 Completed build in 58m 23s on Wed, 20 Nov, 04:27 PM Test Summary: 50975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1538

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/20/19, 16:28

  6. Benni Mack merged patch set 2 11/20/19, 16:28