Review main Merged

62347[TASK] Deprecate TSFE->divSection

Benni Mack CR +2 V +2 Normal +58 −9 updated 11/21/19, 13:27

Commit message

DivSection was used to create GMENU_LAYERS functionality,
injecting global inline JavaScript right after the rendered pages'
<body> tag.

GMENU_LAYERS was removed with TYPO3 v8, however the property
was still replaced every single time in the TYPO3 Frontend when
a USER_INT was on the page. This is not needed anymore, marking
the property as unused. That's why it is deprecated.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 58

  1. Benni Mack uploaded patch set 1 11/20/19, 18:31

  2. TYPO3com voted on patch set 1 V +1 11/20/19, 18:38 Completed build in 07m 00s on Wed, 20 Nov, 06:38 PM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38503

  3. Benni Mack uploaded patch set 2 11/21/19, 11:20

  4. TYPO3com voted on patch set 2 V -1 11/21/19, 11:28 Completed build in 07m 36s on Thu, 21 Nov, 11:28 AM Test Summary: 48352 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38534

  5. TYPO3com voted on patch set 2 V +1 11/21/19, 11:49 Completed build in 36m 01s on Thu, 21 Nov, 11:49 AM Test Summary: 48353 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38534

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 11/21/19, 11:50

  7. Georg Ringer voted on patch set 2 V +2 CR +2 11/21/19, 13:27

  8. Georg Ringer merged patch set 3 11/21/19, 13:27