Review main Merged

62349[FEATURE] Unified PageTS resolving and parsing

Benni Mack CR +2 V +2 Hard +659 −113 updated 11/21/19, 15:48

Commit message

This change introduces two new API classes relevant for PageTSconfig:

- PageTsConfigLoader
- PageTsConfigParser

The loader class collects all PageTS found in a rootline, which was
previously available in two places - BackendUtility and TSFE, although
they were similar, they were not the same and error-prone in the past.

The previous "TsConfigParser" class had an unusal dependency to
the BackendConditionMatcher only, which did not even allow to send in
custom arguments.

The TSFE part is now also evaluating TSconfig conditions properly,
which was not the case in the past. This part is also now cached properly.

The TSconfig inclusion ("include from the list of TSconfig inclusions")
functionality is now built into the Info module.

In addition, the hard-coded "ConditionMatcher" is now seamlessly
injected into the parsing process, allowing
- Decoupling of Logic and Implementation of parsing in different contexts
- Making the ConditionMatcher extensible by having a new ConditionMatcherInterface

In the next steps:
- the UserTsConfig parsing can be applied separately and split from BE_USER
- ConditionMatcher Interface can be used properly
- TypoScriptParser can be split up
- BackendUtility can be cleaned up further.

The following functionality is deprecated:
- TYPO3\CMS\Core\Configuration\TsConfigParser
- TYPO3\CMS\Backend\Utility\BackendUtility::getRawPagesTSconfig()

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 19

Review log 814

  1. Benni Mack uploaded patch set 1 11/20/19, 23:30

  2. TYPO3com voted on patch set 1 V -1 11/20/19, 23:37 Completed build in 07m 06s on Wed, 20 Nov, 11:37 PM Test Summary: 15 of 48733 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38508

  3. Benni Mack uploaded patch set 2 11/20/19, 23:59

  4. Benni Mack uploaded patch set 3 11/20/19, 23:59

  5. TYPO3com voted on patch set 2 V -1 11/20/19, 23:59 Completed build in 15s on Wed, 20 Nov, 11:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38509

  6. TYPO3com voted on patch set 3 V -1 11/21/19, 00:18 Completed build in 19m 00s on Thu, 21 Nov, 12:18 AM Test Summary: 24 of 48733 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38510

  7. Benni Mack uploaded patch set 4 11/21/19, 00:47

  8. TYPO3com voted on patch set 4 V +1 11/21/19, 01:11 Completed build in 10m 47s on Thu, 21 Nov, 01:11 AM Test Summary: 48377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38511

  9. Benni Mack updated the commit message in patch set 5 11/21/19, 12:35

  10. TYPO3com voted on patch set 5 V -1 11/21/19, 12:44 Completed build in 08m 27s on Thu, 21 Nov, 12:44 PM Test Summary: 48144 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38542

  11. TYPO3com voted on patch set 5 V +1 11/21/19, 13:12 Completed build in 44m 58s on Thu, 21 Nov, 01:12 PM Test Summary: 48377 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38542

  12. Georg Ringer voted on patch set 5 V +1 CR +1 11/21/19, 13:24

  13. Anja Leichsenring voted on patch set 5 V +2 CR +2 11/21/19, 15:48

  14. Anja Leichsenring merged patch set 6 11/21/19, 15:48