62353[BUGFIX] Only load TypoScript files on directory import
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Rémy DANIEL +1
- Felix P. +1
- Steffen Frese +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Steffen Frese +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+3 −1
- typo3/sysext/core/Documentation/Changelog/9.0/Feature-82812-NewSyntaxForImportingTypoScriptFiles.rst+1 −4
- typo3/sysext/core/Documentation/Changelog/master/Important-89720-OnlyTypoScriptFilesLoadedOnDirectoryImport.rstnew+23 −0
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+0 −14
Review log 1316
-
Mathias Brodala uploaded patch set 1 11/21/19, 09:34
-
TYPO3com voted on patch set 1 V -1 11/21/19, 09:41 Completed build in 06m 59s on Thu, 21 Nov, 09:41 AM Test Summary: 4 of 48709 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38520
-
Mathias Brodala uploaded patch set 2 11/21/19, 16:25
-
TYPO3com voted on patch set 2 V +1 11/21/19, 16:32 Completed build in 06m 57s on Thu, 21 Nov, 04:32 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38566
-
Jörg Bösche commented on patch set 2 CR -1 11/25/19, 15:55
IMO, we should add a info part to the documentation and/or a RST file for this patch, that are only *.typoscript files will be included, if the directory is defined. Older extensions or legacy projects with v9 might use the *.txt extension as well and will not include setup.txt anymore. Might be a breaking change in v9. Should change the documentation from # Import all files of a directory @import 'EXT:myproject/Configuration/TypoScript/' to # Import all *.typoscript files of a directory @import 'EXT:myproject/Configuration/TypoScript/' -
Mathias Brodala uploaded patch set 3 11/26/19, 12:35
-
Mathias Brodala commented on patch set 3 11/26/19, 12:36
> Patch Set 2: Code-Review-1 > > IMO, we should add a info part to the documentation and/or a RST file for this patch, ... I've adjusted the original RST now and also added an Important RST to point at this change in behavior. -
TYPO3com voted on patch set 3 V +1 11/26/19, 12:42 Completed build in 06m 51s on Tue, 26 Nov, 12:42 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38838
-
Rémy DANIEL voted on patch set 3 CR +1 11/26/19, 14:13
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 12/18/19, 14:06
-
Susi Moog commented on patch set 3 12/20/19, 07:30
after checking the original issue / review (https://review.typo3.org/c/Packages/TYPO3.CMS/+/54446/) and looking at this a bit closer I'm actually unsure about this change. The syntax was pretty straightforward before (/ includes all files, /*.typoscript includes only typoscript) without any magic. Now we are adjusting that to implicitly restrict the inclusion - maybe we should change the docs instead? -
Anja Leichsenring commented on patch set 3 12/20/19, 10:29
> Patch Set 3: > > after checking the original issue / review (https://review.typo3.org/c/Packages/TYPO3.CMS/+/54446/) and looking at this a bit closer I'm actually unsure about this change. The syntax was pretty straightforward before (/ includes all files, /*.typoscript includes only typoscript) without any magic. Now we are adjusting that to implicitly restrict the inclusion - maybe we should change the docs instead? I like that. The more explicit, the better. -
Steffen Frese voted on patch set 3 V +1 CR +1 01/14/20, 12:50
-
Felix P. voted on patch set 3 CR +1 01/14/20, 13:16
-
Benni Mack voted on patch set 3 V +2 CR +2 01/14/20, 13:34
-
Benni Mack merged patch set 4 01/14/20, 13:34