Review main Merged

62354[TASK] Update symfony dependencies to 4.4 or 5.0

Benni Mack CR +2 V +2 Expert +578 −919 updated 11/21/19, 12:52

Commit message

TYPO3 Core v10 should rely on Symfony 4.4 (LTS release)
and add support for 5.0 automatically.

Symfony 4.4 made breaking changes to the Mailer and Mime components
which now need adaptions.

Used composer command:

composer req "symfony/config":"^4.4 || ^5.0" \
"symfony/console":"^4.4 || ^5.0" \
"symfony/dependency-injection":"^4.4 || ^5.0" \
"symfony/expression-language":"^4.4 || ^5.0" \
"symfony/finder":"^4.4 || ^5.0" \
"symfony/mailer":"^4.4 || ^5.0" \
"symfony/mime":"^4.4 || ^5.0" \
"symfony/property-access":"^4.4 || ^5.0" \
"symfony/property-info":"^4.4 || ^5.0" \
"symfony/routing":"^4.4 || ^5.0" \
"symfony/yaml":"^4.4 || ^5.0" --update-with-all-dependencies

Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 27 updates, 0 removals
  - Updating symfony/polyfill-ctype (v1.11.0 => v1.12.0)
  - Updating symfony/filesystem (v4.3.1 => v4.4.0)
  - Updating symfony/config (v4.3.2 => v4.4.0)
  - Updating symfony/service-contracts (v1.1.2 => v1.1.8)
  - Updating symfony/polyfill-php73 (v1.11.0 => v1.12.0)
  - Updating symfony/polyfill-mbstring (v1.11.0 => v1.12.0)
  - Updating symfony/console (v4.3.1 => v4.4.0)
  - Updating symfony/dependency-injection (v4.3.2 => v4.4.0)
  - Updating symfony/var-exporter (v4.3.1 => v4.4.0)
  - Updating symfony/cache-contracts (v1.1.1 => v1.1.7)
  - Updating psr/log (1.0.2 => 1.1.2)
  - Updating symfony/cache (v4.3.1 => v4.4.0)
  - Updating symfony/expression-language (v4.3.1 => v4.4.0)
  - Updating symfony/finder (v4.3.3 => v4.4.0)
  - Updating symfony/polyfill-php72 (v1.11.0 => v1.12.0)
  - Updating symfony/polyfill-intl-idn (v1.11.0 => v1.12.0)
  - Updating symfony/mime (v4.3.2 => v4.4.0)
  - Updating symfony/event-dispatcher-contracts (v1.1.1 => v1.1.7)
  - Updating symfony/event-dispatcher (v4.3.1 => v4.4.0)
  - Updating doctrine/lexer (v1.0.1 => 1.2.0)
  - Updating egulias/email-validator (2.1.9 => 2.1.11)
  - Updating symfony/mailer (v4.3.2 => v4.4.0)
  - Updating symfony/inflector (v4.3.1 => v4.4.0)
  - Updating symfony/property-access (v4.3.1 => v4.4.0)
  - Updating symfony/property-info (v4.3.1 => v4.4.0)
  - Updating symfony/routing (v4.3.1 => v4.4.0)
  - Updating symfony/yaml (v4.3.1 => v4.4.0)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 1625

  1. Benni Mack uploaded patch set 1 11/21/19, 09:59

  2. Benni Mack uploaded patch set 2 11/21/19, 10:00

  3. TYPO3com voted on patch set 1 V -1 11/21/19, 10:00 Completed build in 37s on Thu, 21 Nov, 10:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38522

  4. TYPO3com voted on patch set 2 V -1 11/21/19, 10:03 Completed build in 03m 37s on Thu, 21 Nov, 10:03 AM Test Summary: 7533 of 48288 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38523

  5. Benni Mack uploaded patch set 3 11/21/19, 10:05

  6. TYPO3com voted on patch set 3 V -1 11/21/19, 10:08 Completed build in 02m 47s on Thu, 21 Nov, 10:08 AM Test Summary: 7786 of 48541 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38524

  7. Susi Moog uploaded patch set 4 11/21/19, 10:55

  8. TYPO3com voted on patch set 4 V -1 11/21/19, 10:58 Completed build in 02m 56s on Thu, 21 Nov, 10:58 AM Test Summary: 203 of 40958 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38528

  9. Susi Moog uploaded patch set 5 11/21/19, 11:05

  10. Susi Moog uploaded patch set 6 11/21/19, 11:07

  11. TYPO3com voted on patch set 5 V -1 11/21/19, 11:08 Completed build in 02m 53s on Thu, 21 Nov, 11:08 AM Test Summary: 203 of 40958 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38529

  12. TYPO3com voted on patch set 6 V -1 11/21/19, 11:11 Completed build in 04m 01s on Thu, 21 Nov, 11:11 AM Test Summary: 203 of 40958 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38531

  13. Susi Moog uploaded patch set 7 11/21/19, 11:12

  14. TYPO3com voted on patch set 7 V -1 11/21/19, 11:21 Completed build in 08m 16s on Thu, 21 Nov, 11:21 AM Test Summary: 200 of 48709 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38532

  15. Susi Moog uploaded patch set 8 11/21/19, 12:12

  16. TYPO3com voted on patch set 8 V -1 11/21/19, 12:15 Completed build in 01m 28s on Thu, 21 Nov, 12:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38540

  17. Susi Moog uploaded patch set 9 11/21/19, 12:20

  18. Oliver Klee commented on patch set 9 11/21/19, 12:21

    MemorySpool.php:116

    Wouldn't an implode work as well (using the implicit toString call)?
  19. TYPO3com voted on patch set 9 V +1 11/21/19, 12:27 Completed build in 07m 13s on Thu, 21 Nov, 12:27 PM Test Summary: 48057 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38541

  20. Benni Mack commented on patch set 9 11/21/19, 12:31

    MemorySpool.php:116 Reply Unresolved

    no, as the Symfony SentMessage class does not have a "__toString()" but only a "toString()" method.
  21. Ralf Zimmermann commented on patch set 9 11/21/19, 12:42

    Services.yaml:38 Unresolved

    Should we restructure all the inline notations?
  22. Anja Leichsenring voted on patch set 9 V +1 CR +1 11/21/19, 12:48

  23. Susi Moog voted on patch set 9 V +1 CR +1 11/21/19, 12:52

  24. Benni Mack voted on patch set 9 V +2 CR +2 11/21/19, 12:52

  25. Benni Mack merged patch set 10 11/21/19, 12:52