Review TYPO3_8-7 Merged

62356[BUGFIX] Remove jumpToUrl function

Dennis Prinse CR +2 V +2 Easy +2 −8 updated 02/28/20, 14:23

Commit message

This patch backports the changes in AbstractLinkBrowserController
which were added in patch #89033. There were some differences
between master and the 8.7 branch, so some adjustments had to be
made to backport the patch properly.

Before, the AbstractLinkBrowserController added a href=#
and an onclick=jumpToUrl() which triggered JavaScript to switch
tabs. In this patch, the onclick=jumpToUrl() function will
be removed from a tab and complete url will be set to the tab
instead.

The onclick=jumpToUrl() function caused problems when switching
tabs while resources were loading.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. Dennis Prinse uploaded patch set 1 11/21/19, 11:06

  2. TYPO3com voted on patch set 1 V +1 11/21/19, 11:15 Completed build in 08m 23s on Thu, 21 Nov, 11:15 AM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3716

  3. Dennis Prinse updated the commit message in patch set 2 12/06/19, 10:47

  4. TYPO3com voted on patch set 2 V -1 12/06/19, 11:00 Completed build in 11m 34s on Fri, 6 Dec, 11:00 AM Test Summary: 6 of 80958 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3748

  5. TYPO3com voted on patch set 2 V +1 12/11/19, 09:32 Completed build in 22h 55m 04s on Wed, 11 Dec, 09:32 AM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3748

  6. Richard Haeser updated the commit message in patch set 3 02/06/20, 14:08

  7. Richard Haeser voted on patch set 3 V +1 CR +1 02/06/20, 14:08

  8. Richard Haeser commented on patch set 3 02/06/20, 14:09

    Benni, we have issues with this for a client in CMS8. As they paid us to fix this, it would be great if we could merge this into core as well.
  9. TYPO3com voted on patch set 3 V +1 02/27/20, 20:03 Completed build in 11m 10s on Thu, 27 Feb, 08:03 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-23

  10. Benni Mack commented on patch set 3 02/27/20, 20:19

    I would be really careful in this area... Just need to be carefully tested in: - Typolink fields (e.g. tt_content.header_link) - Group Fields (e.g. tt_content.pages, tt_content.records via Insert Records) - RTE links (both htmlarea+rte_ckeditor) :( Both with pages, files and linkhandler enhancements (e.g. links to tt_content) while observing the JS console and looking for errors. These are the parts that are really nasty. Also, maybe Markus Klein could share his insights on this one...
  11. Markus Klein commented on patch set 3 CR +1 02/28/20, 08:20

    Looks good to me
  12. Markus Klein commented on patch set 3 V +1 02/28/20, 08:22

    And works
  13. Benni Mack voted on patch set 3 V +2 CR +2 02/28/20, 14:23

  14. Benni Mack merged patch set 4 02/28/20, 14:23