62356[BUGFIX] Remove jumpToUrl function
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1014
-
Dennis Prinse uploaded patch set 1 11/21/19, 11:06
-
TYPO3com voted on patch set 1 V +1 11/21/19, 11:15 Completed build in 08m 23s on Thu, 21 Nov, 11:15 AM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3716
-
Dennis Prinse updated the commit message in patch set 2 12/06/19, 10:47
-
TYPO3com voted on patch set 2 V -1 12/06/19, 11:00 Completed build in 11m 34s on Fri, 6 Dec, 11:00 AM Test Summary: 6 of 80958 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3748
-
TYPO3com voted on patch set 2 V +1 12/11/19, 09:32 Completed build in 22h 55m 04s on Wed, 11 Dec, 09:32 AM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3748
-
Richard Haeser updated the commit message in patch set 3 02/06/20, 14:08
-
Richard Haeser voted on patch set 3 V +1 CR +1 02/06/20, 14:08
-
Richard Haeser commented on patch set 3 02/06/20, 14:09
Benni, we have issues with this for a client in CMS8. As they paid us to fix this, it would be great if we could merge this into core as well. -
TYPO3com voted on patch set 3 V +1 02/27/20, 20:03 Completed build in 11m 10s on Thu, 27 Feb, 08:03 PM Test Summary: 101784 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-23
-
Benni Mack commented on patch set 3 02/27/20, 20:19
I would be really careful in this area... Just need to be carefully tested in: - Typolink fields (e.g. tt_content.header_link) - Group Fields (e.g. tt_content.pages, tt_content.records via Insert Records) - RTE links (both htmlarea+rte_ckeditor) :( Both with pages, files and linkhandler enhancements (e.g. links to tt_content) while observing the JS console and looking for errors. These are the parts that are really nasty. Also, maybe Markus Klein could share his insights on this one... -
Markus Klein commented on patch set 3 CR +1 02/28/20, 08:20
Looks good to me -
Markus Klein commented on patch set 3 V +1 02/28/20, 08:22
And works -
Benni Mack voted on patch set 3 V +2 CR +2 02/28/20, 14:23
-
Benni Mack merged patch set 4 02/28/20, 14:23