62361[BUGFIX] Convert date objects to string in finisher options
Commit message
Review
-
Code review CR +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
-
Verified V +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+18 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/Date.php2new+47 −0
- typo3/sysext/form/Classes/Domain/Model/FormElements/DatePicker.php+19 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/StringableFormElementInterface.php2new+28 −0
- typo3/sysext/form/Classes/Hooks/FormElementHooks.php+0 −16
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+7 −19
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+1 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+1 −1
- typo3/sysext/form/Tests/Unit/Domain/Finishers/AbstractFinisherTest.php2+70 −0
- typo3/sysext/form/ext_localconf.php+0 −3
Review log 2638
Show 813 earlier messages
-
Mathias Brodala uploaded patch set 1 11/21/19, 19:09
-
TYPO3com voted on patch set 1 V -1 11/21/19, 19:10 Completed build in 11s on Thu, 21 Nov, 07:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38569
-
Mathias Brodala uploaded patch set 2 11/21/19, 19:10
-
TYPO3com voted on patch set 2 V -1 11/21/19, 19:20 Completed build in 09m 37s on Thu, 21 Nov, 07:20 PM Test Summary: 47081 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38570
-
TYPO3com voted on patch set 2 V +1 11/21/19, 19:29 Completed build in 28m 23s on Thu, 21 Nov, 07:29 PM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38570
-
Mathias Brodala uploaded patch set 3 11/22/19, 08:46
-
Mathias Brodala uploaded patch set 4 11/22/19, 08:50
-
TYPO3com voted on patch set 3 V +1 11/22/19, 08:54 Completed build in 08m 00s on Fri, 22 Nov, 08:54 AM Test Summary: 48089 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38584
-
TYPO3com voted on patch set 4 V +1 11/22/19, 09:27 Completed build in 34m 44s on Fri, 22 Nov, 09:27 AM Test Summary: 48093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38586
-
Ralf Zimmermann voted on patch set 4 V -1 11/22/19, 11:49
-
Ralf Zimmermann uploaded patch set 5 11/22/19, 11:59
-
Ralf Zimmermann voted on patch set 5 V +1 CR +1 11/22/19, 11:59
-
Ralf Zimmermann commented on patch set 6 11/22/19, 12:01
Published edit on patch set 5.
-
Ralf Zimmermann voted on patch set 6 V +1 CR +1 11/22/19, 12:01
-
TYPO3com voted on patch set 5 V +1 11/22/19, 12:09 Completed build in 09m 22s on Fri, 22 Nov, 12:09 PM Test Summary: 48093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38621
-
TYPO3com voted on patch set 6 V -1 11/22/19, 12:11 Completed build in 08m 03s on Fri, 22 Nov, 12:11 PM Test Summary: 2 of 48437 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38622
-
TYPO3com voted on patch set 6 V +1 11/22/19, 12:20 Completed build in 25m 19s on Fri, 22 Nov, 12:20 PM Test Summary: 48092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38622
-
Ralf Zimmermann updated the commit message in patch set 7 11/22/19, 12:49
-
Ralf Zimmermann voted on patch set 7 V +1 CR +1 11/22/19, 12:50
-
TYPO3com voted on patch set 7 V +1 11/22/19, 12:57 Completed build in 07m 08s on Fri, 22 Nov, 12:57 PM Test Summary: 48093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38628
-
Daniel Goerz voted on patch set 7 V +1 11/22/19, 13:10
-
Daniel Goerz commented on patch set 7 11/22/19, 13:12
Date.php:43The baseSetup has a different default here (d.m.Y) -
Mathias Brodala commented on patch set 7 11/22/19, 13:16
Date.php:43Reply UnresolvedThat's true but this is what the RenderAllFormValuesViewHelper does as of now. -
Susi Moog commented on patch set 7 CR -1 11/22/19, 13:19
StringableFormElementInterface.php:19if the interface is meant to be used by others please document it. if not, mark it as internal. -
Susi Moog commented on patch set 7 11/22/19, 13:23
AbstractFinisherTest.php:488all the tests should btw not test directly via the abstract but either via a real or a test implementation fixture. additionally: do not mock the interface and it's return types, this is part of the unit. -
Susi Moog voted on patch set 7 V -1 11/22/19, 13:23
-
Mathias Brodala uploaded patch set 8 11/22/19, 13:33
-
Mathias Brodala commented on patch set 8 11/22/19, 13:34
StringableFormElementInterface.php:19Reply UnresolvedIt's now marked as internal which can be changed before TYPO3v10 LTS if it makes sense to allow 3rd party packages to use it.AbstractFinisherTest.php:488Reply UnresolvedThis was updated using an anonymous class now which performs the actual conversion logic. -
TYPO3com voted on patch set 8 V -1 11/22/19, 13:41 Completed build in 07m 49s on Fri, 22 Nov, 01:41 PM Test Summary: 47859 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38634
-
TYPO3com voted on patch set 8 V +1 11/22/19, 13:46 Completed build in 20m 48s on Fri, 22 Nov, 01:46 PM Test Summary: 48092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38634
-
Mathias Brodala uploaded patch set 9 11/22/19, 13:56
-
TYPO3com voted on patch set 9 V +1 11/22/19, 14:04 Completed build in 07m 15s on Fri, 22 Nov, 02:04 PM Test Summary: 48093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38638
-
Ralf Zimmermann voted on patch set 9 V +1 11/23/19, 09:15
-
Björn Jacob voted on patch set 9 V +1 CR +1 11/23/19, 11:11
-
Ralf Zimmermann voted on patch set 9 V +2 CR +2 11/23/19, 11:27
-
Ralf Zimmermann merged patch set 10 11/23/19, 11:27
-
Stephan Großberndt commented on patch set 10 01/17/20, 12:07
I stumbled upon this when searching for a solution for this in TYPO3 v9 due to using a DatePicker date in the subject of an email finisher. As this is a bugfix, why no backport to v9? -
Mathias Brodala commented on patch set 10 01/17/20, 12:26
> I stumbled upon this when searching for a solution for this in TYPO3 v9 due to using a DatePicker date in the subject of an email finisher. As this is a bugfix, why no backport to v9? Due to the complexity of this fix chances are high that we'd introduce an error in v9, so it was decided to not backport it.