Review main Merged

62365[BUGFIX] Ensure hoa/core is not a dependency

Benni Mack CR +2 V +2 Easy +3 −4 updated 11/22/19, 09:58

Commit message

When running composer update --prefer-lowest
the abandoned package hoa/core could still
be installed via codeception/codeception,
which in turn results in issues running
our test suite.

See https://github.com/hoaproject/Protocol/issues/8

This is also needed for PHP 7.4 compatibility.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Benni Mack uploaded patch set 1 11/22/19, 08:47

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 08:56 Completed build in 09m 00s on Fri, 22 Nov, 08:56 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38585

  3. Benni Mack updated the commit message in patch set 2 11/22/19, 09:27

  4. TYPO3com voted on patch set 2 V +1 11/22/19, 09:45 Completed build in 08m 50s on Fri, 22 Nov, 09:45 AM Test Summary: 48085 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38591

  5. Benni Mack voted on patch set 2 V +2 CR +2 11/22/19, 09:58

  6. Benni Mack merged patch set 3 11/22/19, 09:58