Review main Merged

62367[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant

Benni Mack CR +2 V +2 Normal +60 −42 updated 11/22/19, 11:10

Commit message

This resolves the most common issues related to
PHP 7.4 PHP changes:
- implode() argument order
- using "{}" instead of "[]" in PHP array keys
- PHP notices for invalid array key access

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 25

Show 5 more files

Review log 56

  1. Benni Mack uploaded patch set 1 11/22/19, 09:09

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 09:42 Completed build in 21m 02s on Fri, 22 Nov, 09:42 AM Test Summary: 48084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38588

  3. Susi Moog voted on patch set 1 V +1 CR +1 11/22/19, 10:55

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 11/22/19, 11:08

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/22/19, 11:10

  6. Benni Mack merged patch set 2 11/22/19, 11:10