Review 9.5 Merged

62374[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant

Benni Mack CR +2 V +2 Normal +60 −42 updated 11/22/19, 12:40

Commit message

This resolves the most common issues related to
PHP 7.4 PHP changes:
- implode() argument order
- using "{}" instead of "[]" in PHP array keys
- PHP notices for invalid array key access

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 24

Show 4 more files

Review log 45

  1. Benni Mack uploaded patch set 1 11/22/19, 11:19

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 11:33 Completed build in 11m 18s on Fri, 22 Nov, 11:33 AM Test Summary: 50975 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1556

  3. Susi Moog voted on patch set 1 CR +1 11/22/19, 11:48

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/22/19, 12:40

  5. Benni Mack merged patch set 2 11/22/19, 12:40