Review main Merged

62379[TASK] Use TSFE for fetching site and language

Benni Mack CR +2 V +2 Normal +45 −107 updated 11/23/19, 14:47

Commit message

There are various places where TSFE is instantiated, and holding
the proper information about a site and the current language.

Using the properties from there avoid using $GLOBALS[TYPO3_REQUEST]
in "safe" places.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1119

  1. Benni Mack uploaded patch set 1 11/22/19, 15:39

  2. Benni Mack updated the commit message in patch set 2 11/22/19, 15:41

  3. TYPO3com voted on patch set 1 V -1 11/22/19, 15:41 Completed build in 25s on Fri, 22 Nov, 03:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38653

  4. TYPO3com voted on patch set 2 V -1 11/22/19, 15:41 Completed build in 28s on Fri, 22 Nov, 03:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38654

  5. Benni Mack uploaded patch set 3 11/22/19, 15:58

  6. TYPO3com voted on patch set 3 V -1 11/22/19, 16:05 Completed build in 07m 28s on Fri, 22 Nov, 04:05 PM Test Summary: 124 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38658

  7. Benni Mack uploaded patch set 4 11/22/19, 16:53

  8. TYPO3com voted on patch set 4 V -1 11/22/19, 17:00 Completed build in 07m 14s on Fri, 22 Nov, 05:00 PM Test Summary: 104 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38672

  9. Benni Mack uploaded patch set 5 11/22/19, 17:08

  10. TYPO3com voted on patch set 5 V -1 11/22/19, 17:15 Completed build in 07m 40s on Fri, 22 Nov, 05:15 PM Test Summary: 48 of 48428 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38676

  11. Benni Mack uploaded patch set 6 11/22/19, 17:45

  12. TYPO3com voted on patch set 6 V -1 11/22/19, 17:45 Completed build in 19s on Fri, 22 Nov, 05:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38681

  13. TYPO3com commented on patch set 6 11/22/19, 19:28 Completed build in 1h 43m 34s on Fri, 22 Nov, 07:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38681

  14. Benni Mack uploaded patch set 7 11/22/19, 19:29

  15. TYPO3com voted on patch set 7 V +1 11/22/19, 19:37 Completed build in 07m 44s on Fri, 22 Nov, 07:37 PM Test Summary: 48084 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38700

  16. Susi Moog voted on patch set 7 CR +1 11/23/19, 09:37

  17. Susi Moog voted on patch set 7 V +1 11/23/19, 09:47

  18. Daniel Goerz voted on patch set 7 V +2 CR +2 11/23/19, 14:47

  19. Daniel Goerz merged patch set 8 11/23/19, 14:47