Review main Abandoned

62380[WIP][FEATURE] Introduce global static routes

Susi Moog CR 0 V 0 Normal +176 −26 updated 11/09/22, 16:20

Commit message

- todo: foreign unique handling
- upgrade wizards
- beautify

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 915

  1. Susi Moog uploaded patch set 1 11/22/19, 15:51

  2. TYPO3com voted on patch set 1 V -1 11/22/19, 15:52 Completed build in 13s on Fri, 22 Nov, 03:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38656

  3. Susi Moog uploaded patch set 2 11/22/19, 16:28

  4. TYPO3com voted on patch set 2 V +1 11/22/19, 16:36 Completed build in 07m 57s on Fri, 22 Nov, 04:36 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38663

  5. Daniel Goerz uploaded patch set 3 11/22/19, 18:56

  6. TYPO3com voted on patch set 3 V -1 11/22/19, 18:57 Completed build in 16s on Fri, 22 Nov, 06:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38692

  7. Daniel Goerz uploaded patch set 4 11/23/19, 09:04

  8. TYPO3com voted on patch set 4 V +1 11/23/19, 09:11 Completed build in 07m 09s on Sat, 23 Nov, 09:11 AM Test Summary: 48103 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38705

  9. Susi Moog uploaded patch set 5 12/18/19, 21:39

  10. Susi Moog updated the commit message in patch set 6 12/18/19, 21:40

  11. TYPO3com voted on patch set 5 V -1 12/18/19, 21:48 Completed build in 08m 23s on Wed, 18 Dec, 09:48 PM Test Summary: 3381 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39520

  12. TYPO3com voted on patch set 6 V -1 12/18/19, 21:50 Completed build in 09m 36s on Wed, 18 Dec, 09:50 PM Test Summary: 3381 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39521

  13. Jörg Bösche commented on patch set 6 01/13/20, 09:46

    StaticRouteResolver.php:50 Unresolved

    Add new line.

    StaticRouteResolver.php:54 Unresolved

    Add new line.

    StaticRouteResolver.php:62 Unresolved

    protected vs private.

    StaticRouteResolver.php:93 Unresolved

    Add return type of static function()... Add parameter types

    StaticRouteResolver.php:105 Unresolved

    Add return type of static function()... Add parameter types
  14. Susi Moog abandoned the change 06/08/20, 16:01

  15. Susi Moog commented on patch set 6 11/09/22, 16:20

    rebase, new try, three years later... https://review.typo3.org/c/Packages/TYPO3.CMS/+/76524