Review main Merged

62382[BUGFIX] Use current site language in indexed search by default

Benni Mack CR +2 V +2 Easy +6 −1 updated 11/26/19, 07:00

Commit message

Using Indexed Search plugin, one can customize the language selector,
however, you needed a TypoScript condition, as Site Handling support
was not possible yet.

The default behaviour should be to only search in the selected language,
which can be achieved by looking into the current language.

The default option is now set to "current". Existing implementations
still using conditions continue to keep working.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Oli Bartsch +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 11/22/19, 16:13

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 16:21 Completed build in 07m 43s on Fri, 22 Nov, 04:21 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38660

  3. Susi Moog voted on patch set 1 V +1 CR +1 11/22/19, 18:35

  4. Daniel Gorges voted on patch set 1 V +1 CR +1 11/26/19, 04:34

  5. Oli Bartsch voted on patch set 1 CR +1 11/26/19, 06:00

  6. Susi Moog voted on patch set 1 V +2 CR +2 11/26/19, 07:00

  7. Susi Moog merged patch set 2 11/26/19, 07:00