62385[BUGFIX] Avoid applying parameter inflation during route resolving
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
- Michael Telgkamp +1
-
Verified V +2 Done
- Susi Moog +2
- Michael Telgkamp +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Routing/Enhancer/InflatableEnhancerInterface.phpnew+25 −0
- typo3/sysext/core/Classes/Routing/Enhancer/PluginEnhancer.php+2 −5
- typo3/sysext/core/Classes/Routing/Enhancer/SimpleEnhancer.php+7 −4
- typo3/sysext/core/Classes/Routing/PageRouter.php+5 −0
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php2+175 −0
Review log 2331
Show 46 earlier messages
-
Oliver Hader uploaded patch set 1 11/22/19, 17:25
-
Oliver Hader updated the commit message in patch set 2 11/22/19, 17:26
-
TYPO3com voted on patch set 1 V +1 11/22/19, 17:33 Completed build in 07m 59s on Fri, 22 Nov, 05:33 PM Test Summary: 48102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38677
-
TYPO3com voted on patch set 2 V +1 11/22/19, 17:35 Completed build in 07m 06s on Fri, 22 Nov, 05:35 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38679
-
Oliver Hader uploaded patch set 3 11/23/19, 09:51
-
Oliver Hader updated the commit message in patch set 4 11/23/19, 09:56
-
TYPO3com voted on patch set 3 V -1 11/23/19, 09:59 Completed build in 07m 52s on Sat, 23 Nov, 09:59 AM Test Summary: 9 of 48505 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38711
-
Oliver Hader uploaded patch set 5 11/23/19, 10:01
-
TYPO3com voted on patch set 4 V -1 11/23/19, 10:03 Completed build in 07m 00s on Sat, 23 Nov, 10:03 AM Test Summary: 9 of 48250 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38712
-
Oliver Hader updated the commit message in patch set 6 11/23/19, 10:06
-
TYPO3com voted on patch set 5 V +1 11/23/19, 10:10 Completed build in 08m 40s on Sat, 23 Nov, 10:10 AM Test Summary: 48167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38714
-
Benni Mack voted on patch set 6 V +1 CR +1 11/23/19, 10:11
-
TYPO3com voted on patch set 6 V +1 11/23/19, 10:14 Completed build in 07m 42s on Sat, 23 Nov, 10:14 AM Test Summary: 48167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38716
-
Benni Mack voted on patch set 6 V 0 CR 0 11/23/19, 10:14
-
Oliver Hader voted on patch set 6 CR +1 11/23/19, 10:25
-
Oliver Hader voted on patch set 6 CR 0 11/23/19, 10:25
-
Oliver Hader commented on patch set 6 11/23/19, 10:46
-
Oliver Hader commented on patch set 7 11/23/19, 10:47
Published edit on patch set 6. -
Oliver Hader commented on patch set 7 11/23/19, 10:47
EnhancerSiteRequestTest.php:783ReplyDone -
TYPO3com voted on patch set 7 V +1 11/23/19, 10:54 Completed build in 07m 33s on Sat, 23 Nov, 10:54 AM Test Summary: 48167 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38727
-
Michael Telgkamp commented on patch set 7 CR -1 11/23/19, 15:57
In `VariableProcessor::inflateArray` there should be the change from `$this->resolveHash($key)` to `$this->resolveHash((string)$key)` as a hash of a string might be number only (e.g. `md5('ximaz')`) and a number only sting used as key of an array is converted to a number and thus results in an exception when used for the function `resolveHash(string $hash): string`. It is not the main focus of the issue, so it could also be considered to be solved in an additional ticket. -
Oliver Hader commented on patch set 7 11/23/19, 17:03
> Patch Set 7: Code-Review-1 > > In `VariableProcessor::inflateArray` there should be the change from `$this->resolveHash($key)` to `$this->resolveHash((string)$key)` as a hash of a string might be number only (e.g. `md5('ximaz')`) and a number only sting used as key of an array is converted to a number and thus results in an exception when used for the function `resolveHash(string $hash): string`. It is not the main focus of the issue, so it could also be considered to be solved in an additional ticket. Sure, let's integrate a test for that, it fits perfectly well... -
Oliver Hader commented on patch set 7 11/23/19, 17:20
> Patch Set 7: > > > Patch Set 7: Code-Review-1 > > > > In `VariableProcessor::inflateArray` there should be the change from `$this->resolveHash($key)` to `$this->resolveHash((string)$key)` as a hash of a string might be number only (e.g. `md5('ximaz')`) and a number only sting used as key of an array is converted to a number and thus results in an exception when used for the function `resolveHash(string $hash): string`. It is not the main focus of the issue, so it could also be considered to be solved in an additional ticket. > > Sure, let's integrate a test for that, it fits perfectly well... No change required since this is considered already when a hash is being generated, see https://github.com/TYPO3/TYPO3.CMS/blob/e6903b8b866aa4be211c31e507ec9e80158d967b/typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php#L49 Anyway, let's add a test for it. -
Oliver Hader uploaded patch set 8 11/23/19, 17:20
-
Oliver Hader commented on patch set 8 11/23/19, 17:21
> Patch Set 7: > > > Patch Set 7: > > > > > Patch Set 7: Code-Review-1 > > > > > > In `VariableProcessor::inflateArray` there should be the change from `$this->resolveHash($key)` to `$this->resolveHash((string)$key)` as a hash of a string might be number only (e.g. `md5('ximaz')`) and a number only sting used as key of an array is converted to a number and thus results in an exception when used for the function `resolveHash(string $hash): string`. It is not the main focus of the issue, so it could also be considered to be solved in an additional ticket. > > > > Sure, let's integrate a test for that, it fits perfectly well... > > No change required since this is considered already when a hash is being generated, see > https://github.com/TYPO3/TYPO3.CMS/blob/e6903b8b866aa4be211c31e507ec9e80158d967b/typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php#L49 > > Anyway, let's add a test for it. Additional test, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/62385/7..8/typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php -
TYPO3com voted on patch set 8 V +1 11/23/19, 17:27 Completed build in 06m 57s on Sat, 23 Nov, 05:27 PM Test Summary: 48227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38781
-
Michael Telgkamp commented on patch set 8 V +1 CR +1 11/25/19, 08:30
Looks good for me and applying the patch to 9.5 it also works with the actual problem I had in the 9.5 project. -
Benni Mack voted on patch set 8 CR +2 11/27/19, 21:11
-
Frank Nägler voted on patch set 8 CR +1 11/27/19, 21:35
-
Susi Moog commented on patch set 8 V +2 11/28/19, 06:05
tested on my live web site :-D -
Susi Moog merged patch set 9 11/28/19, 06:06
EnhancerSiteRequestTest.php:783