Review main Merged

62388[TASK] Migrate FileMetadataOverlayAspect to PSR-14 listener

Benni Mack CR +2 V +2 Easy +22 −24 updated 11/25/19, 08:51

Commit message

The existing slot in EXT:frontend for overlaying sys-file-metadata
is migrated to a PSR-14 event listener.

Although this is not a new feature, this is a perfect example of
a migration from SignalSlot to PSR-14 event listener.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Daniel Gorges +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Benni Mack uploaded patch set 1 11/22/19, 17:58

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 18:05 Completed build in 07m 12s on Fri, 22 Nov, 06:05 PM Test Summary: 48103 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38683

  3. Benni Mack updated the commit message in patch set 2 11/22/19, 19:22

  4. Daniel Goerz voted on patch set 2 CR +1 11/22/19, 19:28

  5. TYPO3com voted on patch set 2 V +1 11/22/19, 19:34 Completed build in 11m 13s on Fri, 22 Nov, 07:34 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38698

  6. Susi Moog voted on patch set 2 V +1 CR +1 11/23/19, 16:25

  7. Daniel Gorges voted on patch set 2 V +1 CR +1 11/25/19, 08:44

  8. Susi Moog voted on patch set 2 V +2 CR +2 11/25/19, 08:51

  9. Susi Moog merged patch set 3 11/25/19, 08:51