Review main Merged

62389[FEATURE] Render fieldset labels in form templates

Mathias Brodala CR +2 V +2 Normal +107 −63 updated 11/23/19, 15:14

Commit message

This adds fieldset labels as separators on the summary page and mails.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1522

  1. Mathias Brodala uploaded patch set 1 11/22/19, 18:13

  2. TYPO3com voted on patch set 1 V +1 11/22/19, 18:20 Completed build in 07m 21s on Fri, 22 Nov, 06:20 PM Test Summary: 48103 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38684

  3. Mathias Brodala uploaded patch set 2 11/22/19, 18:21

  4. TYPO3com voted on patch set 2 V +1 11/22/19, 18:28 Completed build in 07m 07s on Fri, 22 Nov, 06:28 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38686

  5. Mathias Brodala uploaded patch set 3 11/23/19, 12:31

  6. Ralf Zimmermann voted on patch set 3 V +1 CR +1 11/23/19, 12:32

  7. Mathias Brodala uploaded patch set 4 11/23/19, 12:38

  8. TYPO3com voted on patch set 3 V -1 11/23/19, 12:39 Completed build in 07m 48s on Sat, 23 Nov, 12:39 PM Test Summary: 38104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38739

  9. Ralf Zimmermann voted on patch set 4 V +1 CR +1 11/23/19, 12:44

  10. TYPO3com voted on patch set 4 V +1 11/23/19, 12:46 Completed build in 07m 27s on Sat, 23 Nov, 12:46 PM Test Summary: 48179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38741

  11. Björn Jacob commented on patch set 5 11/23/19, 14:26

    Published edit on patch set 4.
  12. Ralf Zimmermann voted on patch set 5 V +1 CR +1 11/23/19, 14:27

  13. Björn Jacob commented on patch set 6 11/23/19, 14:30

    Published edit on patch set 5.
  14. Ralf Zimmermann rebased onto patch set 7 11/23/19, 14:32

  15. TYPO3com voted on patch set 5 V -1 11/23/19, 14:35 Completed build in 08m 37s on Sat, 23 Nov, 02:35 PM Test Summary: 48174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38753

  16. TYPO3com voted on patch set 6 V +1 11/23/19, 14:38 Completed build in 08m 44s on Sat, 23 Nov, 02:38 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38755

  17. TYPO3com voted on patch set 7 V +1 11/23/19, 14:42 Completed build in 09m 14s on Sat, 23 Nov, 02:41 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38756

  18. Susi Moog voted on patch set 7 V +1 CR +1 11/23/19, 14:49

  19. Daniel Goerz voted on patch set 7 V +2 CR +2 11/23/19, 15:13

  20. Daniel Goerz merged patch set 8 11/23/19, 15:13

  21. Björn Jacob voted on patch set 8 V +1 CR +1 11/23/19, 15:13

  22. Björn Jacob commented on patch set 8 11/23/19, 15:14

    Tested it. Was too slow. Nicely done.