62389[FEATURE] Render fieldset labels in form templates
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Björn Jacob +1
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Björn Jacob +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Feature-82706-RenderFieldsetLabelsInFormTemplates.rstnew+26 −0
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+18 −14
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+1 −0
- typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.html+28 −21
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Html.html+30 −23
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Plaintext.html+4 −5
Review log 1522
-
Mathias Brodala uploaded patch set 1 11/22/19, 18:13
-
TYPO3com voted on patch set 1 V +1 11/22/19, 18:20 Completed build in 07m 21s on Fri, 22 Nov, 06:20 PM Test Summary: 48103 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38684
-
Mathias Brodala uploaded patch set 2 11/22/19, 18:21
-
TYPO3com voted on patch set 2 V +1 11/22/19, 18:28 Completed build in 07m 07s on Fri, 22 Nov, 06:28 PM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38686
-
Mathias Brodala uploaded patch set 3 11/23/19, 12:31
-
Ralf Zimmermann voted on patch set 3 V +1 CR +1 11/23/19, 12:32
-
Mathias Brodala uploaded patch set 4 11/23/19, 12:38
-
TYPO3com voted on patch set 3 V -1 11/23/19, 12:39 Completed build in 07m 48s on Sat, 23 Nov, 12:39 PM Test Summary: 38104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38739
-
Ralf Zimmermann voted on patch set 4 V +1 CR +1 11/23/19, 12:44
-
TYPO3com voted on patch set 4 V +1 11/23/19, 12:46 Completed build in 07m 27s on Sat, 23 Nov, 12:46 PM Test Summary: 48179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38741
-
Björn Jacob commented on patch set 5 11/23/19, 14:26
Published edit on patch set 4. -
Ralf Zimmermann voted on patch set 5 V +1 CR +1 11/23/19, 14:27
-
Björn Jacob commented on patch set 6 11/23/19, 14:30
Published edit on patch set 5. -
Ralf Zimmermann rebased onto patch set 7 11/23/19, 14:32
-
TYPO3com voted on patch set 5 V -1 11/23/19, 14:35 Completed build in 08m 37s on Sat, 23 Nov, 02:35 PM Test Summary: 48174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38753
-
TYPO3com voted on patch set 6 V +1 11/23/19, 14:38 Completed build in 08m 44s on Sat, 23 Nov, 02:38 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38755
-
TYPO3com voted on patch set 7 V +1 11/23/19, 14:42 Completed build in 09m 14s on Sat, 23 Nov, 02:41 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38756
-
Susi Moog voted on patch set 7 V +1 CR +1 11/23/19, 14:49
-
Daniel Goerz voted on patch set 7 V +2 CR +2 11/23/19, 15:13
-
Daniel Goerz merged patch set 8 11/23/19, 15:13
-
Björn Jacob voted on patch set 8 V +1 CR +1 11/23/19, 15:13
-
Björn Jacob commented on patch set 8 11/23/19, 15:14
Tested it. Was too slow. Nicely done.