Review main Merged

62390[FEATURE] Unified PSR-14 event for modifying the SystemInformationToolbarItem

Benni Mack CR +2 V +2 Hard +171 −102 updated 11/23/19, 12:50

Commit message

The SystemInformationToolbarItem now has one unified PSR-14 Event instead
of the previous signals used by SignalSlotDispatcher.

New Event class is called:

- TYPO3\CMS\Backend\Backend\Event\SystemInformationToolbarCollectorEvent

and provides access to the actual SystemInformationToolbarItem allowing
to add messages or new systemInformation blocks by using the API methods
there.

The existing signals are deprecated, and all existing code is migrated
to the PSR-14 event.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 16

Review log 57

  1. Benni Mack uploaded patch set 1 11/22/19, 18:39

  2. TYPO3com voted on patch set 1 V -1 11/22/19, 18:47 Completed build in 07m 18s on Fri, 22 Nov, 06:47 PM Test Summary: 65 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38689

  3. Benni Mack uploaded patch set 2 11/23/19, 09:07

  4. TYPO3com voted on patch set 2 V +1 11/23/19, 09:15 Completed build in 07m 44s on Sat, 23 Nov, 09:15 AM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38706

  5. Susi Moog voted on patch set 2 V +1 CR +1 11/23/19, 09:25

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 11/23/19, 12:49

  7. Daniel Goerz merged patch set 3 11/23/19, 12:50