Review main Merged

62391[TASK] Housekeeping in Extension Manager Code

Benni Mack CR +2 V +2 Hard +378 −560 updated 10/19/20, 21:30

Commit message

This patch mainly:
- Does use statements in all EM code
- Removes unused fields "sponsorlink", "sponsorlogo" and "sponsorname" of mirrors XML
- Removes unused methods in internal classes

It is time to clean up... First one is to get an overview of what is still needed.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Susi Moog +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 34

Show 14 more files

Review log 1013

  1. Benni Mack uploaded patch set 1 11/22/19, 19:15

  2. TYPO3com voted on patch set 1 V -1 11/22/19, 19:22 Completed build in 07m 29s on Fri, 22 Nov, 07:22 PM Test Summary: 36 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38695

  3. Susi Moog commented on patch set 1 CR -1 11/23/19, 09:11

    DependencyUtility.php:238 Unresolved

    this method is still in use, see `\TYPO3\CMS\Extensionmanager\Utility\DependencyUtility::checkDependencies` -> `$methodName = 'check' . ucfirst($identifier) . 'Dependency';`
  4. Benni Mack uploaded patch set 2 11/23/19, 09:31

  5. TYPO3com voted on patch set 2 V -1 11/23/19, 09:38 Completed build in 06m 49s on Sat, 23 Nov, 09:38 AM Test Summary: 12 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38709

  6. Benni Mack uploaded patch set 3 11/23/19, 10:11

  7. Oliver Hader voted on patch set 3 CR +1 11/23/19, 10:16

  8. TYPO3com voted on patch set 3 V +1 11/23/19, 10:18 Completed build in 07m 30s on Sat, 23 Nov, 10:18 AM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38719

  9. Susi Moog voted on patch set 3 V +1 CR +1 11/23/19, 10:26

  10. Oliver Hader voted on patch set 3 V +2 CR +2 11/23/19, 11:06

  11. Oliver Hader merged patch set 4 11/23/19, 11:06

  12. Christian Kuhn commented on patch set 4 10/19/20, 21:27

    ExtensionRepository.php:90

    This is broken: The extbase query builder only has one argument for logicalAnd().

    ExtensionRepository.php:110 Unresolved

    this is broken, too?
  13. Christian Kuhn commented on patch set 4 10/19/20, 21:30

    ExtensionRepository.php:90 Reply Unresolved

    forget it ...