62391[TASK] Housekeeping in Extension Manager Code
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Susi Moog +1
-
Verified V +2 Done
- Oliver Hader +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 34
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+3 −4
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+18 −13
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+8 −5
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+24 −46
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+16 −12
- typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php+17 −13
- typo3/sysext/extensionmanager/Classes/Controller/UpdateScriptController.php+3 −2
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+16 −12
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+6 −3
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php+8 −52
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php+10 −8
- typo3/sysext/extensionmanager/Classes/Domain/Model/Mirrors.php+3 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Repository.php+10 −7
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php3+34 −24
- typo3/sysext/extensionmanager/Classes/Domain/Repository/RepositoryRepository.php+5 −3
- typo3/sysext/extensionmanager/Classes/Report/ExtensionStatus.php+35 −27
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+22 −16
- typo3/sysext/extensionmanager/Classes/Task/UpdateExtensionListTask.php+10 −23
- typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php+0 −42
- typo3/sysext/extensionmanager/Classes/Utility/Importer/ExtensionListUtility.php+0 −7
Show 14 more files
- typo3/sysext/extensionmanager/Classes/Utility/Importer/MirrorListUtility.php+14 −8
- typo3/sysext/extensionmanager/Classes/Utility/Parser/AbstractMirrorXmlParser.php+2 −60
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPullParser.php+0 −9
- typo3/sysext/extensionmanager/Classes/Utility/Parser/MirrorXmlPushParser.php+0 −9
- typo3/sysext/extensionmanager/Classes/Utility/Parser/XmlParserFactory.php+5 −5
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+4 −7
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php1+19 −28
- typo3/sysext/extensionmanager/Classes/Utility/DownloadUtility.php+21 −15
- typo3/sysext/extensionmanager/Classes/Utility/EmConfUtility.php+3 −2
- typo3/sysext/extensionmanager/Classes/Utility/ExtensionModelUtility.php+12 −9
- typo3/sysext/extensionmanager/Classes/Utility/FileHandlingUtility.php+18 −16
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+17 −44
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+14 −12
- typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php+1 −16
Review log 1013
-
Benni Mack uploaded patch set 1 11/22/19, 19:15
-
TYPO3com voted on patch set 1 V -1 11/22/19, 19:22 Completed build in 07m 29s on Fri, 22 Nov, 07:22 PM Test Summary: 36 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38695
-
Susi Moog commented on patch set 1 CR -1 11/23/19, 09:11
-
Benni Mack uploaded patch set 2 11/23/19, 09:31
-
TYPO3com voted on patch set 2 V -1 11/23/19, 09:38 Completed build in 06m 49s on Sat, 23 Nov, 09:38 AM Test Summary: 12 of 48448 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38709
-
Benni Mack uploaded patch set 3 11/23/19, 10:11
-
Oliver Hader voted on patch set 3 CR +1 11/23/19, 10:16
-
TYPO3com voted on patch set 3 V +1 11/23/19, 10:18 Completed build in 07m 30s on Sat, 23 Nov, 10:18 AM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38719
-
Susi Moog voted on patch set 3 V +1 CR +1 11/23/19, 10:26
-
Oliver Hader voted on patch set 3 V +2 CR +2 11/23/19, 11:06
-
Oliver Hader merged patch set 4 11/23/19, 11:06
-
Christian Kuhn commented on patch set 4 10/19/20, 21:27
ExtensionRepository.php:90This is broken: The extbase query builder only has one argument for logicalAnd().ExtensionRepository.php:110Unresolvedthis is broken, too? -
Christian Kuhn commented on patch set 4 10/19/20, 21:30
ExtensionRepository.php:90Reply Unresolvedforget it ...
DependencyUtility.php:238Unresolved