Review TYPO3_8-7 Merged

62394[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant

Benni Mack CR +2 V +2 Normal +44 −26 updated 11/22/19, 13:06

Commit message

This resolves the most common issues related to
PHP 7.4 PHP changes:
- implode() argument order
- using "{}" instead of "[]" in PHP array keys
- PHP notices for invalid array key access

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 58

  1. Benni Mack commented on patch set 1 11/22/19, 12:40

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php * typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php * typo3/sysext/core/Classes/Charset/CharsetConverter.php * typo3/sysext/core/Classes/DataHandling/DataHandler.php * typo3/sysext/core/Classes/DataHandling/SlugHelper.php * typo3/sysext/core/Classes/Routing/Enhancer/PageTypeDecorator.php * typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php * typo3/sysext/core/Classes/Service/FlexFormService.php * typo3/sysext/core/Classes/Site/Entity/Site.php * typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php * typo3/sysext/extbase/Classes/Reflection/ClassSchema.php * typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php
  2. TYPO3com voted on patch set 1 V -1 11/22/19, 12:41 Completed build in 13s on Fri, 22 Nov, 12:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3717

  3. Benni Mack uploaded patch set 2 11/22/19, 12:52

  4. Benni Mack commented on patch set 2 11/22/19, 12:53

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 11/22/19, 13:02 Completed build in 09m 04s on Fri, 22 Nov, 01:01 PM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3718

  6. TYPO3com voted on patch set 2 V +1 11/22/19, 13:06 Completed build in 22m 20s on Fri, 22 Nov, 01:06 PM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3718

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/22/19, 13:06

  8. Benni Mack merged patch set 3 11/22/19, 13:06