62394[TASK] Make PHP code of TYPO3 Core PHP 7.4 compliant
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 18
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+2 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineExpandCollapseState.php+6 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+5 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+2 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −6
- typo3/sysext/core/Classes/Html/HtmlParser.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −1
- typo3/sysext/core/Classes/Localization/LanguageStore.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+4 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+1 −1
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+1 −1
- typo3/sysext/extbase/Classes/Service/FlexFormService.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Widget/Controller/PaginateControllerTest.php+3 −0
- typo3/sysext/frontend/Classes/ContentObject/FilesContentObject.php+6 −2
Review log 58
-
Benni Mack commented on patch set 1 11/22/19, 12:40
Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php * typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php * typo3/sysext/core/Classes/Charset/CharsetConverter.php * typo3/sysext/core/Classes/DataHandling/DataHandler.php * typo3/sysext/core/Classes/DataHandling/SlugHelper.php * typo3/sysext/core/Classes/Routing/Enhancer/PageTypeDecorator.php * typo3/sysext/core/Classes/Routing/Enhancer/VariableProcessor.php * typo3/sysext/core/Classes/Service/FlexFormService.php * typo3/sysext/core/Classes/Site/Entity/Site.php * typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php * typo3/sysext/extbase/Classes/Reflection/ClassSchema.php * typo3/sysext/scheduler/Classes/CronCommand/NormalizeCommand.php -
TYPO3com voted on patch set 1 V -1 11/22/19, 12:41 Completed build in 13s on Fri, 22 Nov, 12:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3717
-
Benni Mack uploaded patch set 2 11/22/19, 12:52
-
Benni Mack commented on patch set 2 11/22/19, 12:53
This change is ready for review. -
TYPO3com voted on patch set 2 V -1 11/22/19, 13:02 Completed build in 09m 04s on Fri, 22 Nov, 01:01 PM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3718
-
TYPO3com voted on patch set 2 V +1 11/22/19, 13:06 Completed build in 22m 20s on Fri, 22 Nov, 01:06 PM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3718
-
Benni Mack voted on patch set 2 V +2 CR +2 11/22/19, 13:06
-
Benni Mack merged patch set 3 11/22/19, 13:06