Review 9.5 Merged

62399[BUGFIX] StaticRouteResolver returns 404 on invalid static route

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 11/23/19, 12:50

Commit message

Currently, the Static Route Resolver returns HTTP status code 200
on invalid routes, but a 404 is the correct response.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 11/23/19, 12:33

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/23/19, 12:44 Completed build in 10m 47s on Sat, 23 Nov, 12:44 PM Test Summary: 50994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1571

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 11/23/19, 12:50

  4. Daniel Goerz merged patch set 2 11/23/19, 12:50