Review 9.5 Merged

62408[TASK] Update friendsofphp/php-cs-fixer to 2.16.1

Benni Mack CR +2 V +2 Easy +19 −18 updated 11/27/19, 12:58

Commit message

composer require --dev friendsofphp/php-cs-fixer:"^2.16.1"

Raising the version brings support for running the fixer with
PHP 7.4.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Tobi Kretschmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Benni Mack commented on patch set 1 11/26/19, 15:47

    Cherry Picked from branch master. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/core/composer.json
  2. TYPO3com voted on patch set 1 V -1 11/26/19, 15:47 Completed build in 12s on Tue, 26 Nov, 03:47 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1591

  3. Oliver Klee commented on patch set 1 11/26/19, 16:03

    composer.json:73 Unresolved

    Traffic accident here.
  4. Benni Mack uploaded patch set 2 11/27/19, 06:58

  5. Benni Mack commented on patch set 2 11/27/19, 06:58

    This change is ready for review.
  6. Benni Mack commented on patch set 2 11/27/19, 06:59

    > Patch Set 1: > > (1 comment) I thought it was still marked as WIP ;) But a review would be highly appreciated now, really!
  7. TYPO3com voted on patch set 2 V +1 11/27/19, 07:10 Completed build in 12m 04s on Wed, 27 Nov, 07:10 AM Test Summary: 50998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1594

  8. Tobi Kretschmann voted on patch set 2 CR +1 11/27/19, 08:18

  9. Tobi Kretschmann voted on patch set 2 V +1 11/27/19, 08:20

  10. Oliver Klee voted on patch set 2 CR +1 11/27/19, 08:39

  11. Benni Mack voted on patch set 2 V +2 CR +2 11/27/19, 12:58

  12. Benni Mack merged patch set 3 11/27/19, 12:58