Review TYPO3_8-7 Merged

62410[TASK] Update friendsofphp/php-cs-fixer to 2.16.1

Benni Mack CR +2 V +2 Normal +102 −106 updated 12/10/19, 12:37

Commit message

Raising the version brings support for running the fixer with
PHP 7.4.

Used composer command:
composer require --dev friendsofphp/php-cs-fixer:"^2.16.1" --update-with-dependencies

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack commented on patch set 1 11/27/19, 12:58

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * composer.json * composer.lock * typo3/sysext/core/composer.json
  2. TYPO3com voted on patch set 1 V -1 11/27/19, 12:58 Completed build in 11s on Wed, 27 Nov, 12:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3726

  3. Andreas Kienast commented on patch set 1 11/28/19, 08:20

    I've prepared a patch to update the Symfony packages to their latest allowed version: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62444
  4. Benni Mack uploaded patch set 2 12/10/19, 12:06

  5. Benni Mack commented on patch set 2 12/10/19, 12:08

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V +1 12/10/19, 12:16 Completed build in 09m 14s on Tue, 10 Dec, 12:16 PM Test Summary: 80410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3756

  7. Oliver Klee voted on patch set 2 CR +1 12/10/19, 12:30

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/10/19, 12:37

  9. Benni Mack merged patch set 3 12/10/19, 12:37