Review 9.5 Merged

62411[BUGFIX] Avoid applying parameter inflation during route resolving

Susi Moog CR +2 V +2 Normal +217 −10 updated 12/16/19, 16:57

Commit message

Remaining parameters need to be deflated (prepared and normalized to
strings and fitting into Symfony route length and literal constraints)
during route generation.

However, when resolving a route remaining query parameters have to be
kept as is - explained in more detail in the following examples based
on using enhancer with namespace set to 'app':

* https://example.org/page/route-value/app__value=inject
  + previously assigned `app[value]=inject` -> dirty -> rejected
  + not inflated anymore, kept as `app_value`
* https://example.org/page/route-value/app__other=inject
  + previously assigned `app[other]=inject` -> okay, wrong namespace
  + not inflated anymore, kept as `app__other`
* https://example.org/page/route-value/[32+ characters]=inject
  + arbitrary characters lead to OutOfRangeException -> no valid hash
  + previously `md5('app__@any__value')` assigned `app[@any][value]`
    -> dirty -> rejected
  + not inflated anymore, kept as `md5('app__@any__value')`

Basically the mentioned OutOfRangeException revealed that misbehavior,
hacking `VariableProcessor::resolveHash` would not have solve issues
with (incorrectly) merged query parameters - but would have hidden it.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1015

  1. Susi Moog commented on patch set 1 11/28/19, 06:06

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 11/28/19, 06:15 Completed build in 09m 34s on Thu, 28 Nov, 06:15 AM Test Summary: 9 of 51532 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1598

  3. Susi Moog commented on patch set 2 11/29/19, 10:54

    Published edit on patch set 1.
  4. TYPO3com voted on patch set 2 V -1 11/29/19, 11:46 Completed build in 49m 24s on Fri, 29 Nov, 11:46 AM Test Summary: 10 of 50268 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1616

  5. TYPO3com commented on patch set 2 11/29/19, 11:53 Completed build in 1h 45m 38s on Fri, 29 Nov, 11:53 AM Test Summary: 9 of 51532 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1616

  6. Oliver Hader commented on patch set 2 CR -1 12/04/19, 08:34

    Will take care later...
  7. Oliver Hader wrote 12/16/19, 15:28

    Removed Verified-1 by TYPO3com <noreply@typo3.com>
  8. Oliver Hader commented on patch set 2 12/16/19, 15:29

    ... not time currently ...
  9. Oliver Hader rebased onto patch set 3 12/16/19, 15:30

  10. TYPO3com voted on patch set 3 V -1 12/16/19, 15:40 Completed build in 10m 23s on Mon, 16 Dec, 03:40 PM Test Summary: 9 of 72656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1720

  11. Oliver Hader commented on patch set 3 CR -1 12/16/19, 16:23

    On it again...
  12. Oliver Hader uploaded patch set 4 12/16/19, 16:40

  13. TYPO3com voted on patch set 4 V +1 12/16/19, 16:50 Completed build in 09m 24s on Mon, 16 Dec, 04:49 PM Test Summary: 72056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1721

  14. Oliver Hader voted on patch set 4 V +2 CR +2 12/16/19, 16:57

  15. Oliver Hader merged patch set 5 12/16/19, 16:57