Review main Merged

62413[BUGFIX] StaticRouteResolver returns 404 on invalid static route

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/23/19, 12:33

Commit message

Currently, the Static Route Resolver returns HTTP status code 200
on invalid routes, but a 404 is the correct response.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Mathias Brodala +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 11/23/19, 10:02

  2. TYPO3com voted on patch set 1 V -1 11/23/19, 10:11 Completed build in 08m 33s on Sat, 23 Nov, 10:11 AM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38715

  3. Mathias Brodala voted on patch set 1 CR +1 11/23/19, 10:12

  4. TYPO3com voted on patch set 1 V +1 11/23/19, 10:15 Completed build in 20m 42s on Sat, 23 Nov, 10:15 AM Test Summary: 48104 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38715

  5. Susi Moog voted on patch set 1 CR +1 11/23/19, 10:16

  6. Susi Moog voted on patch set 1 V +1 11/23/19, 12:24

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 11/23/19, 12:33

  8. Daniel Goerz merged patch set 2 11/23/19, 12:33