Review main Merged

62415[BUGFIX] Respect user mount points within FormPersistenceManager

Ralf Zimmermann CR +2 V +2 Easy +35 −7 updated 11/24/19, 10:48

Commit message

Let the FormPersistenceManager respect user mount points and
auto created file mounts while retrieving and creating folders
which are configured within
"TYPO3.CMS.Form.persistenceManager.allowedFileMounts".

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1419

  1. Ralf Zimmermann uploaded patch set 1 11/23/19, 12:07

  2. Ralf Zimmermann commented on patch set 1 11/23/19, 12:11

    For testing create a file mount and add it to a backend user group. You can also configure some user home directories https://docs.typo3.org/m/typo3/reference-inside/8.7/en-us/CoreArchitecture/AccessControl/MoreAboutFileMounts/Index.html#home-directories
  3. TYPO3com voted on patch set 1 V +1 11/23/19, 12:18 Completed build in 07m 19s on Sat, 23 Nov, 12:18 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38736

  4. Ralf Zimmermann commented on patch set 2 11/23/19, 14:03

    Published edit on patch set 1.
  5. TYPO3com voted on patch set 2 V +1 11/23/19, 14:10 Completed build in 07m 26s on Sat, 23 Nov, 02:10 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38748

  6. Björn Jacob commented on patch set 2 CR -1 11/23/19, 15:21

    Matthias is on it.
  7. Mathias Brodala uploaded patch set 3 11/23/19, 15:38

  8. Mathias Brodala commented on patch set 3 V +1 CR +1 11/23/19, 15:40

    Tested both with the mentioned "groupHomePath" feature as well as a regular file mount assigned to the (non-admin) BE user's group. Both cases where tested with nested folder paths in "allowedFileMounts" which did not exist before.
  9. TYPO3com voted on patch set 3 V +1 11/23/19, 15:46 Completed build in 07m 28s on Sat, 23 Nov, 03:46 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38769

  10. Björn Jacob commented on patch set 3 CR -1 11/24/19, 08:51

    Testing
  11. Björn Jacob updated the commit message in patch set 4 11/24/19, 08:52

  12. Björn Jacob updated the commit message in patch set 5 11/24/19, 08:52

  13. TYPO3com voted on patch set 4 V -1 11/24/19, 09:00 Completed build in 07m 55s on Sun, 24 Nov, 09:00 AM Test Summary: 48152 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38790

  14. TYPO3com voted on patch set 5 V +1 11/24/19, 09:00 Completed build in 08m 15s on Sun, 24 Nov, 09:00 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38791

  15. Mathias Brodala voted on patch set 5 V +1 CR +1 11/24/19, 09:02

  16. Ralf Zimmermann voted on patch set 5 V +1 CR +1 11/24/19, 09:47

  17. Björn Jacob commented on patch set 5 V +1 CR +1 11/24/19, 10:09

    Tested intensively. Works like a charm and learnt a lot. Crazy features we've got :)
  18. Ralf Zimmermann voted on patch set 5 V +2 CR +2 11/24/19, 10:48

  19. Ralf Zimmermann merged patch set 6 11/24/19, 10:48