62418[TASK] Follow-up: Introduce native pagination for lists
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Pagination/ArrayPaginator.php+5 −5
- typo3/sysext/core/Documentation/Changelog/master/Feature-89603-IntroduceNativePaginationForLists.rst+1 −1
- typo3/sysext/core/Tests/Unit/Pagination/ArrayPaginatorTest.php+7 −6
- typo3/sysext/extbase/Classes/Pagination/QueryResultPaginator.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Pagination/QueryResultPaginatorTest.php+7 −6
Review log 1012
-
Alexander Schnitzler uploaded patch set 1 11/23/19, 13:36
-
Mathias Brodala commented on patch set 1 11/23/19, 13:45
-
Sebastian Fischer voted on patch set 1 CR +1 11/23/19, 13:45
-
TYPO3com voted on patch set 1 V +1 11/23/19, 13:46 Completed build in 09m 42s on Sat, 23 Nov, 01:46 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38746
-
Alexander Schnitzler uploaded patch set 2 11/23/19, 13:47
-
TYPO3com voted on patch set 2 V +1 11/23/19, 13:55 Completed build in 07m 58s on Sat, 23 Nov, 01:55 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38747
-
Mathias Brodala commented on patch set 2 11/23/19, 14:19
This does not make sense IMO. Private only makes sense for classes which can be extended to hide internal implementation details. A final class cannot be extended so there is no need for "private". -
Alexander Schnitzler commented on patch set 2 11/23/19, 14:33
Reply
Right, it's not needed but it doesn't hurt neither. One might have a look at the class, miss the final and think: Ah, great, I can access those properties in a sub class. To me, private is a logical consequence as it visualizes (again) that this is internal logic, not to be messed with. -
Mathias Brodala commented on patch set 2 11/23/19, 14:46
Reply
IMO making something private is a decision which must be done intentional to hide internal implementation details in case extending classes could mess with them. Again, that's impossible here. If we ever decide to mark these classes as "non-final", thus intentionally allow extension, we should look at the code at that time to decide if something must be "private". And if you miss the "final" you'll notice as soon as you try to extend the class. ;-) -
Daniel Goerz voted on patch set 2 V +1 CR +1 11/23/19, 14:48
-
Susi Moog commented on patch set 2 V +2 CR +2 11/23/19, 14:51
Reply Unresolved
Especially in case we remove the final at some point, I want to have the private by default, as visibility should then be an active decision we take. -
Susi Moog merged patch set 3 11/23/19, 14:52
Unresolved