62419[BUGFIX] Re-enable caching and centralize UserTSconfig in BE_USER
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Markus Klein +1
-
Verified V +2 Done
- Susi Moog +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1726
Show 1 earlier messages
-
Benni Mack uploaded patch set 1 11/23/19, 14:16
-
TYPO3com voted on patch set 1 V -1 11/23/19, 14:24 Completed build in 07m 18s on Sat, 23 Nov, 02:24 PM Test Summary: 19 of 48515 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38751
-
Benni Mack uploaded patch set 2 11/23/19, 14:45
-
TYPO3com voted on patch set 2 V +1 11/23/19, 14:53 Completed build in 07m 32s on Sat, 23 Nov, 02:53 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38760
-
Tobi Kretschmann voted on patch set 2 CR +1 11/26/19, 16:18
-
Oliver Klee commented on patch set 2 CR -1 11/26/19, 17:16
I hate cliff-hangers! ;-) -
Benni Mack commented on patch set 2 11/27/19, 07:00
Reply
HAHAHHA! -
Benni Mack updated the commit message in patch set 3 11/27/19, 07:01
-
Benni Mack commented on patch set 3 11/27/19, 07:02
Reply Unresolved
Now that you showed up for review... This reminded me: I wonder if I can create functional tests for this. -
Benni Mack commented on patch set 3 CR -1 11/27/19, 07:02
will try to come up with tests. -
TYPO3com voted on patch set 3 V +1 11/27/19, 07:10 Completed build in 08m 51s on Wed, 27 Nov, 07:10 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38849
-
Benni Mack uploaded patch set 4 12/27/19, 15:44
-
TYPO3com voted on patch set 4 V -1 12/27/19, 15:44 Completed build in 19s on Fri, 27 Dec, 03:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39600
-
Benni Mack uploaded patch set 5 12/27/19, 15:45
-
TYPO3com voted on patch set 5 V -1 12/27/19, 15:54 Completed build in 08m 53s on Fri, 27 Dec, 03:54 PM Test Summary: 69122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39601
-
TYPO3com voted on patch set 5 V +1 12/27/19, 16:18 Completed build in 41m 46s on Fri, 27 Dec, 04:18 PM Test Summary: 69131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39601
-
Markus Klein commented on patch set 5 CR -1 01/14/20, 16:42
BackendUserAuthentication.php:1412Unresolvedwas only for admin beforeBackendUserAuthentication.php:1432Unresolvedshould stay like before: see typo3/sysext/backend/Classes/Configuration/TsConfigParser.php:96BackendUserAuthenticationTest.php:82Unresolvedshouldn't we better use \n here instead of a line break in the php file? -
Markus Klein uploaded patch set 6 01/14/20, 16:47
-
Markus Klein voted on patch set 6 V +1 CR +1 01/14/20, 16:47
-
Markus Klein uploaded patch set 7 01/14/20, 16:50
-
TYPO3com voted on patch set 6 V +1 01/14/20, 16:57 Completed build in 09m 40s on Tue, 14 Jan, 04:56 PM Test Summary: 69605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39923
-
TYPO3com voted on patch set 7 V -1 01/14/20, 17:02 Completed build in 11m 40s on Tue, 14 Jan, 05:02 PM Test Summary: 1 of 70055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39924
-
TYPO3com voted on patch set 7 V +1 01/14/20, 17:09 Completed build in 30m 33s on Tue, 14 Jan, 05:09 PM Test Summary: 69605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39924
-
Markus Klein voted on patch set 7 V +1 CR +1 01/14/20, 17:09
-
Susi Moog voted on patch set 7 V +2 CR +2 01/14/20, 18:04
-
Susi Moog merged patch set 8 01/14/20, 18:04