Review main Merged

62419[BUGFIX] Re-enable caching and centralize UserTSconfig in BE_USER

Benni Mack CR +2 V +2 Normal +65 −41 updated 01/14/20, 18:04

Commit message

In order to continue sorting out various places when UserTSconfig
should be used, and how to properly use caching and condition
matching, compiling of UserTSconfig is now centralized into one method.

In addition, this patch actually now caches the UserTSconfig
again, in the "hash" cache, which wasn't the case before in v10.0+.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Markus Klein +1
  • Verified V +2 Done
    • Susi Moog +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1726

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 11/23/19, 14:16

  1. TYPO3com voted on patch set 1 V -1 11/23/19, 14:24 Completed build in 07m 18s on Sat, 23 Nov, 02:24 PM Test Summary: 19 of 48515 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38751

  2. Benni Mack uploaded patch set 2 11/23/19, 14:45

  3. TYPO3com voted on patch set 2 V +1 11/23/19, 14:53 Completed build in 07m 32s on Sat, 23 Nov, 02:53 PM Test Summary: 48181 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38760

  4. Tobi Kretschmann voted on patch set 2 CR +1 11/26/19, 16:18

  5. Oliver Klee commented on patch set 2 CR -1 11/26/19, 17:16

    I hate cliff-hangers! ;-)
  6. Benni Mack commented on patch set 2 11/27/19, 07:00

    Reply

    HAHAHHA!
  7. Benni Mack updated the commit message in patch set 3 11/27/19, 07:01

  8. Benni Mack commented on patch set 3 11/27/19, 07:02

    Reply Unresolved

    Now that you showed up for review... This reminded me: I wonder if I can create functional tests for this.
  9. Benni Mack commented on patch set 3 CR -1 11/27/19, 07:02

    will try to come up with tests.
  10. TYPO3com voted on patch set 3 V +1 11/27/19, 07:10 Completed build in 08m 51s on Wed, 27 Nov, 07:10 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38849

  11. Benni Mack uploaded patch set 4 12/27/19, 15:44

  12. TYPO3com voted on patch set 4 V -1 12/27/19, 15:44 Completed build in 19s on Fri, 27 Dec, 03:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39600

  13. Benni Mack uploaded patch set 5 12/27/19, 15:45

  14. TYPO3com voted on patch set 5 V -1 12/27/19, 15:54 Completed build in 08m 53s on Fri, 27 Dec, 03:54 PM Test Summary: 69122 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39601

  15. TYPO3com voted on patch set 5 V +1 12/27/19, 16:18 Completed build in 41m 46s on Fri, 27 Dec, 04:18 PM Test Summary: 69131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39601

  16. Markus Klein commented on patch set 5 CR -1 01/14/20, 16:42

    BackendUserAuthentication.php:1412 Unresolved

    was only for admin before

    BackendUserAuthentication.php:1432 Unresolved

    should stay like before: see typo3/sysext/backend/Classes/Configuration/TsConfigParser.php:96

    BackendUserAuthenticationTest.php:82 Unresolved

    shouldn't we better use \n here instead of a line break in the php file?
  17. Markus Klein uploaded patch set 6 01/14/20, 16:47

  18. Markus Klein voted on patch set 6 V +1 CR +1 01/14/20, 16:47

  19. Markus Klein uploaded patch set 7 01/14/20, 16:50

  20. TYPO3com voted on patch set 6 V +1 01/14/20, 16:57 Completed build in 09m 40s on Tue, 14 Jan, 04:56 PM Test Summary: 69605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39923

  21. TYPO3com voted on patch set 7 V -1 01/14/20, 17:02 Completed build in 11m 40s on Tue, 14 Jan, 05:02 PM Test Summary: 1 of 70055 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39924

  22. TYPO3com voted on patch set 7 V +1 01/14/20, 17:09 Completed build in 30m 33s on Tue, 14 Jan, 05:09 PM Test Summary: 69605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39924

  23. Markus Klein voted on patch set 7 V +1 CR +1 01/14/20, 17:09

  24. Susi Moog voted on patch set 7 V +2 CR +2 01/14/20, 18:04

  25. Susi Moog merged patch set 8 01/14/20, 18:04