Review main Merged

62421[BUGFIX] Use "noreferrer" instead of "noopener noreferrer"

Benni Mack CR +2 V +2 Normal +101 −101 updated 11/25/19, 15:00

Commit message

Various patches introduced a feature to not send the referer
nor the opener information to external links.

However, just because others CMS do it this way,
one should carefully consider WHAT THESE THINGS DO.

So, adding "noreferrer" implicitly includes "noopener".
What this means is that we can save a lot of bytes, save the
environment by producing less bytes and sending them over the wire.

References:
- https://www.w3.org/TR/2011/WD-html5-20110113/links.html#link-type-noreferrer
- https://web.dev/external-anchors-use-rel-noopener/
- https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1013

  1. Benni Mack uploaded patch set 1 11/23/19, 15:31

  2. TYPO3com voted on patch set 1 V +1 11/23/19, 15:39 Completed build in 07m 12s on Sat, 23 Nov, 03:39 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38768

  3. Benni Mack updated the commit message in patch set 2 11/23/19, 15:52

  4. TYPO3com voted on patch set 2 V +1 11/23/19, 16:02 Completed build in 10m 18s on Sat, 23 Nov, 04:02 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38774

  5. Riccardo De Contardi commented on patch set 2 V +1 11/23/19, 16:19

    Tested with - simple typolink object - header link of content element - link in RTE Note: on a plain Typoscript menu (TMENU), when adding an external page with set target=_blank, the rel attribute is not added. Is it correct?
  6. Susi Moog voted on patch set 2 V +1 CR +1 11/23/19, 16:34

  7. Jonas Eberle commented on patch set 2 11/24/19, 08:47

    IMHO "target" should be checked with NOT IN (_self _parent _top). A target="myname" would give the same attack surface as target="_blank". (I just verified with Firefox)
  8. Daniel Goerz uploaded patch set 3 11/24/19, 17:55

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 11/24/19, 17:55

  10. TYPO3com voted on patch set 3 V +1 11/24/19, 18:02 Completed build in 07m 19s on Sun, 24 Nov, 06:02 PM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38802

  11. Susi Moog commented on patch set 3 V +2 CR +2 11/25/19, 06:53

    > Patch Set 2: > > IMHO "target" should be checked with NOT IN (_self _parent _top). > > A target="myname" would give the same attack surface as target="_blank". (I just verified with Firefox) Can you create an issue for that? This change is about changing the attributes from using both to using only 'noreferrer' in all places that used both before. Your remark is as far as I understood about changing the if condition in ContentObjectRenderer on when to add the attribute in general.
  12. Susi Moog merged patch set 4 11/25/19, 06:53

  13. Jonas Eberle commented on patch set 4 11/25/19, 15:00

    I opened a ticket for that: https://forge.typo3.org/issues/89771 - I'll try to take care of it.