Review main Merged

62422[FEATURE] Migrate various Signals to PSR-14 events in system extensions

Benni Mack CR +2 V +2 Expert +1663 −256 updated 12/02/19, 11:02

Commit message

The following new PSR-14 events are added:

TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent
TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent
TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent
TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent
TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent
TYPO3\CMS\Impexp\Event\BeforeImportEvent
TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent
TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent
TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent
TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent
TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent
TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent

They replace the following "old" signals with a deprecation layer:

TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer
TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter
TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter
TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude
TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser
TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation
TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl
TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord
TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss
TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 48

Show 28 more files

Review log 2239

Show 714 earlier messages
  1. Benni Mack uploaded patch set 1 11/23/19, 22:36

  2. TYPO3com voted on patch set 1 V -1 11/23/19, 22:44 Completed build in 07m 33s on Sat, 23 Nov, 10:44 PM Test Summary: 45 of 48505 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38789

  3. Benni Mack uploaded patch set 2 11/25/19, 14:52

  4. TYPO3com voted on patch set 2 V -1 11/25/19, 14:54 Completed build in 02m 31s on Mon, 25 Nov, 02:54 PM Test Summary: 7690 of 48361 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38822

  5. Benni Mack uploaded patch set 3 11/29/19, 15:42

  6. TYPO3com voted on patch set 3 V -1 11/29/19, 15:49 Completed build in 07m 45s on Fri, 29 Nov, 03:49 PM Test Summary: 101 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38952

  7. Benni Mack uploaded patch set 4 11/29/19, 15:56

  8. TYPO3com voted on patch set 4 V -1 11/29/19, 16:02 Completed build in 05m 26s on Fri, 29 Nov, 04:02 PM Test Summary: 11197 of 48644 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38953

  9. Benni Mack uploaded patch set 5 11/29/19, 19:20

  10. TYPO3com voted on patch set 5 V -1 11/29/19, 19:26 Completed build in 05m 30s on Fri, 29 Nov, 07:26 PM Test Summary: 10474 of 48644 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38959

  11. Benni Mack uploaded patch set 6 11/29/19, 19:35

  12. TYPO3com voted on patch set 6 V -1 11/29/19, 19:43 Completed build in 08m 03s on Fri, 29 Nov, 07:43 PM Test Summary: 5703 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38960

  13. Benni Mack uploaded patch set 7 11/29/19, 19:53

  14. TYPO3com voted on patch set 7 V -1 11/29/19, 20:01 Completed build in 07m 27s on Fri, 29 Nov, 08:01 PM Test Summary: 7105 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38962

  1. Benni Mack uploaded patch set 8 11/29/19, 20:14

  2. TYPO3com voted on patch set 8 V -1 11/29/19, 20:22 Completed build in 08m 15s on Fri, 29 Nov, 08:22 PM Test Summary: 101 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38963

  3. Benni Mack uploaded patch set 9 11/29/19, 20:41

  4. TYPO3com voted on patch set 9 V +1 11/29/19, 20:49 Completed build in 08m 12s on Fri, 29 Nov, 08:49 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38966

  5. Benni Mack uploaded patch set 10 11/29/19, 21:26

  6. TYPO3com voted on patch set 10 V +1 11/29/19, 21:36 Completed build in 09m 37s on Fri, 29 Nov, 09:36 PM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38970

  7. Susi Moog uploaded patch set 11 12/01/19, 10:27

  8. Susi Moog commented on patch set 11 V +1 CR +1 12/01/19, 10:28

    Just adjusted comments and events to use a consistent style.
  9. TYPO3com voted on patch set 11 V -1 12/01/19, 10:39 Completed build in 11m 39s on Sun, 1 Dec, 10:39 AM Test Summary: 5882 of 48720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38981

  10. Susi Moog uploaded patch set 12 12/02/19, 07:02

  11. TYPO3com voted on patch set 12 V +1 12/02/19, 07:10 Completed build in 07m 14s on Mon, 2 Dec, 07:10 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38986

  12. Frank Nägler voted on patch set 12 CR +1 12/02/19, 08:16

  13. Andreas Kienast commented on patch set 12 CR -1 12/02/19, 08:19

    Services.yaml:33 Unresolved

    BeforeRecordIsAnalyzedEvent
  14. Andreas Kienast commented on patch set 12 12/02/19, 08:26

    Services.yaml:27 Unresolved

    AfterDataGeneratedForWorkspaceEvent
  15. Andreas Kienast uploaded patch set 13 12/02/19, 08:41

  16. TYPO3com voted on patch set 13 V -1 12/02/19, 08:47 Completed build in 05m 31s on Mon, 2 Dec, 08:47 AM Test Summary: 401 of 10923 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38991

  17. TYPO3com commented on patch set 13 12/02/19, 09:19 Completed build in 43m 25s on Mon, 2 Dec, 09:19 AM Test Summary: 1681 of 48719 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38991

  18. Andreas Kienast uploaded patch set 14 12/02/19, 09:23

  19. TYPO3com voted on patch set 14 V -1 12/02/19, 09:58 Completed build in 16m 54s on Mon, 2 Dec, 09:58 AM Test Summary: 910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38996

  20. TYPO3com commented on patch set 14 12/02/19, 10:06 Completed build in 42m 40s on Mon, 2 Dec, 10:06 AM Test Summary: 36398 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38996

  21. TYPO3com voted on patch set 14 V +1 12/02/19, 10:13 Completed build in 1h 14m 31s on Mon, 2 Dec, 10:12 AM Test Summary: 48375 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38996

  22. Andreas Kienast voted on patch set 14 V +1 CR +1 12/02/19, 10:14

  23. Susi Moog voted on patch set 14 V +2 CR +2 12/02/19, 10:43

  24. Susi Moog merged patch set 15 12/02/19, 10:43

  25. Andreas Kienast commented on patch set 15 12/02/19, 11:02

    LanguagePackService.php:56 Unresolved

    must be null(able)