Review main Merged

62424[BUGFIX] Set nullable typehint within setBackendUserAspect()

Ralf Zimmermann CR +2 V +2 Easy +1 −1 updated 11/24/19, 17:00

Commit message

Use a nullable typehint for the method setBackendUserAspect() within
TYPO3\CMS\Frontend\Middleware\TypoScriptFrontendInitialization to avoid
PHP fatal errors if the backend user does not have backend access rights
for a frontend page.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Björn Jacob +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • Riccardo De Contardi +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Ralf Zimmermann uploaded patch set 1 11/24/19, 11:19

  2. TYPO3com voted on patch set 1 V +1 11/24/19, 11:27 Completed build in 07m 58s on Sun, 24 Nov, 11:27 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38795

  3. Mathias Brodala voted on patch set 1 V +1 CR +1 11/24/19, 11:27

  4. Riccardo De Contardi commented on patch set 1 V +1 11/24/19, 11:28

    tested with the scenario written on https://forge.typo3.org/issues/89763 both SU and using a separate login.
  5. Björn Jacob voted on patch set 1 V +1 CR +1 11/24/19, 11:34

  6. Oliver Klee voted on patch set 1 CR +1 11/24/19, 12:19

  7. Oliver Klee commented on patch set 1 11/24/19, 12:19

    9.5 is not affected?
  8. Björn Jacob commented on patch set 1 11/24/19, 13:54

    Reply

    Nope. Is master only, since the feature went into 10. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/61322.
  9. Daniel Goerz voted on patch set 1 V +2 CR +2 11/24/19, 17:00

  10. Daniel Goerz merged patch set 2 11/24/19, 17:00