62427[BUGFIX] Fix compatibility with symfony/dependency-injection:5.0
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Frank Nägler +1
-
Verified V +2 Done
- Richard Haeser +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 911
-
Benjamin Franzke uploaded patch set 1 11/25/19, 09:57
-
TYPO3com voted on patch set 1 V +1 11/25/19, 10:04 Completed build in 07m 10s on Mon, 25 Nov, 10:04 AM Test Summary: 48161 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38813
-
Benni Mack voted on patch set 1 V +1 CR +1 11/25/19, 15:10
-
Alexander Schnitzler commented on patch set 1 V +1 CR +1 11/26/19, 10:06
ServiceProvider.php:61UnresolvedI know that you are not so much if an IDE guy but we could use a variable here with a doc block, exposing the actual type of $container->get('boot.state') here. -
Richard Haeser updated the commit message in patch set 2 11/27/19, 21:21
-
Richard Haeser voted on patch set 2 V +1 CR +1 11/27/19, 21:21
-
Frank Nägler voted on patch set 2 CR +1 11/27/19, 21:22
-
Frank Nägler voted on patch set 2 V +1 11/27/19, 21:28
-
TYPO3com voted on patch set 2 V +1 11/27/19, 21:29 Completed build in 08m 00s on Wed, 27 Nov, 09:29 PM Test Summary: 48165 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38868
-
Richard Haeser voted on patch set 2 V +2 CR +2 11/27/19, 21:31
-
Richard Haeser merged patch set 3 11/27/19, 21:31
Unresolved